Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Issue 1094014: Merge the partial_snapshots branch back into bleeding_edge. For... (Closed)

Created:
10 years, 9 months ago by Kasper Lund
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Merge the partial_snapshots branch back into bleeding_edge. For now, the custom call generator stuff is disabled. Committed: http://code.google.com/p/v8/source/detail?r=4217

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+829 lines, -7125 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/SConscript View 1 chunk +6 lines, -6 lines 1 comment Download
M src/apinatives.js View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/assembler-arm.cc View 3 chunks +34 lines, -12 lines 0 comments Download
M src/arm/cpu-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/ic-arm.cc View 3 chunks +0 lines, -26 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 1 chunk +1 line, -1 line 1 comment Download
M src/bootstrapper.h View 3 chunks +24 lines, -6 lines 0 comments Download
M src/bootstrapper.cc View 24 chunks +331 lines, -277 lines 0 comments Download
M src/compilation-cache.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/contexts.h View 2 chunks +0 lines, -2 lines 0 comments Download
A + src/date.js View 0 chunks +-1 lines, --1 lines 0 comments Download
D src/date-delay.js View 1 chunk +0 lines, -1089 lines 0 comments Download
M src/debug.cc View 3 chunks +2 lines, -3 lines 1 comment Download
A + src/debug-debugger.js View 0 chunks +-1 lines, --1 lines 0 comments Download
D src/debug-delay.js View 1 chunk +0 lines, -2130 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/frames.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/globals.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/handles.h View 2 chunks +5 lines, -7 lines 0 comments Download
M src/handles.cc View 2 chunks +9 lines, -88 lines 0 comments Download
M src/heap.h View 2 chunks +5 lines, -0 lines 0 comments Download
M src/ia32/ic-ia32.cc View 4 chunks +0 lines, -24 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 chunk +1 line, -1 line 1 comment Download
M src/ic.cc View 11 chunks +4 lines, -13 lines 0 comments Download
A + src/json.js View 0 chunks +-1 lines, --1 lines 0 comments Download
D src/json-delay.js View 1 chunk +0 lines, -268 lines 0 comments Download
M src/jsregexp.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/liveedit.h View 1 chunk +1 line, -1 line 0 comments Download
A + src/liveedit-debugger.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/macros.py View 1 chunk +0 lines, -4 lines 0 comments Download
M src/messages.js View 5 chunks +14 lines, -4 lines 0 comments Download
A + src/mirror-debugger.js View 0 chunks +-1 lines, --1 lines 0 comments Download
D src/mirror-delay.js View 1 chunk +0 lines, -2369 lines 0 comments Download
M src/mksnapshot.cc View 6 chunks +92 lines, -9 lines 1 comment Download
M src/natives.h View 1 chunk +6 lines, -6 lines 0 comments Download
M src/objects.h View 5 chunks +1 line, -32 lines 0 comments Download
M src/objects.cc View 6 chunks +1 line, -67 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/platform-freebsd.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/platform-linux.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/platform-openbsd.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/platform-win32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/property.h View 1 chunk +0 lines, -9 lines 0 comments Download
A + src/regexp.js View 0 chunks +-1 lines, --1 lines 0 comments Download
D src/regexp-delay.js View 1 chunk +0 lines, -497 lines 0 comments Download
M src/runtime.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/serialize.h View 5 chunks +35 lines, -23 lines 0 comments Download
M src/serialize.cc View 5 chunks +8 lines, -10 lines 0 comments Download
M src/snapshot.h View 2 chunks +13 lines, -1 line 0 comments Download
M src/snapshot-common.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M src/snapshot-empty.cc View 1 chunk +11 lines, -1 line 0 comments Download
M src/string.js View 4 chunks +4 lines, -3 lines 0 comments Download
M src/top.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/v8-counters.h View 2 chunks +6 lines, -1 line 0 comments Download
M src/x64/ic-x64.cc View 4 chunks +0 lines, -22 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 1 chunk +1 line, -1 line 1 comment Download
M test/cctest/cctest.status View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-api.cc View 2 chunks +2 lines, -1 line 0 comments Download
M test/cctest/test-assembler-arm.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-serialize.cc View 3 chunks +153 lines, -59 lines 0 comments Download
M test/mjsunit/debug-script.js View 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +6 lines, -6 lines 0 comments Download
M tools/js2c.py View 7 chunks +22 lines, -22 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kasper Lund
10 years, 9 months ago (2010-03-23 11:24:18 UTC) #1
Erik Corry
10 years, 9 months ago (2010-03-23 12:01:49 UTC) #2
LGTM

http://codereview.chromium.org/1094014/diff/1/33
File src/SConscript (right):

http://codereview.chromium.org/1094014/diff/1/33#newcode260
src/SConscript:260: debug-debugger.js
We will break the other builds unless we do this other places too.

http://codereview.chromium.org/1094014/diff/1/54
File src/arm/stub-cache-arm.cc (right):

http://codereview.chromium.org/1094014/diff/1/54#newcode926
src/arm/stub-cache-arm.cc:926: if (false &&
function_info->HasCustomCallGenerator()) {
I will fix this ASAP.

http://codereview.chromium.org/1094014/diff/1/37
File src/debug.cc (right):

http://codereview.chromium.org/1094014/diff/1/37#newcode721
src/debug.cc:721: // Mark this script as native and return successfully.
??

http://codereview.chromium.org/1094014/diff/1/20
File src/ia32/stub-cache-ia32.cc (right):

http://codereview.chromium.org/1094014/diff/1/20#newcode1457
src/ia32/stub-cache-ia32.cc:1457: if (false &&
function_info->HasCustomCallGenerator()) {
Note.

http://codereview.chromium.org/1094014/diff/1/38
File src/mksnapshot.cc (right):

http://codereview.chromium.org/1094014/diff/1/38#newcode102
src/mksnapshot.cc:102: partial_sink_(this) {
This one may trigger a warning on Windows...

http://codereview.chromium.org/1094014/diff/1/46
File src/x64/stub-cache-x64.cc (right):

http://codereview.chromium.org/1094014/diff/1/46#newcode786
src/x64/stub-cache-x64.cc:786: if (false &&
function_info->HasCustomCallGenerator()) {
Note to self...

Powered by Google App Engine
This is Rietveld 408576698