Switch LoadTimeStatsTabHelper to use WebContentsUserData.

Switch LoadTimeStatsTabHelper to use WebContentsUserData.

BUG=107201
TEST=no visible change


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157364

[Avi (use Gerrit), 2012-09-17 20:09:13]

Please review.

[cbentzel, 2012-09-18 13:55:41]

http://codereview.chromium.org/10914323/diff/5001/chrome/browser/net/load_tim...
File chrome/browser/net/load_time_stats.cc (right):

http://codereview.chromium.org/10914323/diff/5001/chrome/browser/net/load_tim...
chrome/browser/net/load_time_stats.cc:257: int
LoadTimeStatsTabHelper::kUserDataKey;
Nit: // static comment? 

Also - would it make sense to explain that the value doesn't matter, or is this
such an idiom for WebContentsUserData that it isn't needed at each key site.

http://codereview.chromium.org/10914323/diff/5001/chrome/browser/ui/tab_conte...
File chrome/browser/ui/tab_contents/tab_contents.cc (right):

http://codereview.chromium.org/10914323/diff/5001/chrome/browser/ui/tab_conte...
chrome/browser/ui/tab_contents/tab_contents.cc:131:
chrome_browser_net::LoadTimeStatsTabHelper::CreateForWebContents(contents);
Should this be created at the same location as before?

[Avi (use Gerrit), 2012-09-18 14:11:47]

https://codereview.chromium.org/10914323/diff/5001/chrome/browser/net/load_ti...
File chrome/browser/net/load_time_stats.cc (right):

https://codereview.chromium.org/10914323/diff/5001/chrome/browser/net/load_ti...
chrome/browser/net/load_time_stats.cc:257: int
LoadTimeStatsTabHelper::kUserDataKey;
This is an idiom; every WebContentsUserData gets one :/

https://codereview.chromium.org/10914323/diff/5001/chrome/browser/ui/tab_cont...
File chrome/browser/ui/tab_contents/tab_contents.cc (right):

https://codereview.chromium.org/10914323/diff/5001/chrome/browser/ui/tab_cont...
chrome/browser/ui/tab_contents/tab_contents.cc:131:
chrome_browser_net::LoadTimeStatsTabHelper::CreateForWebContents(contents);
If there's a dependency in the creation of TabHelpers, they handle it in their
creation. So I'm just alphabetizing here.

[cbentzel, 2012-09-18 14:23:24]

LGTM

On Tue, Sep 18, 2012 at 10:11 AM, <avi@chromium.org> wrote:

>
> https://codereview.chromium.**org/10914323/diff/5001/chrome/**
>
browser/net/load_time_stats.cc<https://codereview.chromium.org/10914323/diff/5001/chrome/browser/net/load_time_stats.cc>
> File chrome/browser/net/load_time_**stats.cc (right):
>
> https://codereview.chromium.**org/10914323/diff/5001/chrome/**
>
browser/net/load_time_stats.**cc#newcode257<https://codereview.chromium.org/10914323/diff/5001/chrome/browser/net/load_time_stats.cc#newcode257>
>
> chrome/browser/net/load_time_**stats.cc:257: int
> LoadTimeStatsTabHelper::**kUserDataKey;
> This is an idiom; every WebContentsUserData gets one :/
>
> https://codereview.chromium.**org/10914323/diff/5001/chrome/**
>
browser/ui/tab_contents/tab_**contents.cc<https://codereview.chromium.org/10914323/diff/5001/chrome/browser/ui/tab_contents/tab_contents.cc>
> File chrome/browser/ui/tab_**contents/tab_contents.cc (right):
>
> https://codereview.chromium.**org/10914323/diff/5001/chrome/**
>
browser/ui/tab_contents/tab_**contents.cc#newcode131<https://codereview.chromium.org/10914323/diff/5001/chrome/browser/ui/tab_contents/tab_contents.cc#newcode131>
>
> chrome/browser/ui/tab_**contents/tab_contents.cc:131:
> chrome_browser_net::**LoadTimeStatsTabHelper::**
> CreateForWebContents(contents)**;
> If there's a dependency in the creation of TabHelpers, they handle it in
> their creation. So I'm just alphabetizing here.
>
>
https://codereview.chromium.**org/10914323/<https://codereview.chromium.org/1...
>

[commit-bot: I haz the power, 2012-09-18 14:25:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/10914323/5001

[commit-bot: I haz the power, 2012-09-18 15:54:07]

Change committed as 157364