Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1897)

Unified Diff: chrome/browser/net/load_time_stats.h

Issue 10914323: Switch LoadTimeStatsTabHelper to use WebContentsUserData. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/net/load_time_stats.cc » ('j') | chrome/browser/net/load_time_stats.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/load_time_stats.h
diff --git a/chrome/browser/net/load_time_stats.h b/chrome/browser/net/load_time_stats.h
index e390595987da4f1d0fa2fa4d2a32526649ae5ac4..4880baedb488855676b8d5e4cc3ed36155ea470d 100644
--- a/chrome/browser/net/load_time_stats.h
+++ b/chrome/browser/net/load_time_stats.h
@@ -15,11 +15,10 @@
#include "base/message_loop.h"
#include "base/time.h"
#include "chrome/browser/net/chrome_url_request_context.h"
+#include "chrome/browser/tab_contents/web_contents_user_data.h"
#include "content/public/browser/web_contents_observer.h"
#include "net/base/network_delegate.h"
-class TabContents;
-
namespace base {
class Histogram;
}
@@ -118,12 +117,12 @@ class LoadTimeStats {
DISALLOW_COPY_AND_ASSIGN(LoadTimeStats);
};
-// A WebContentsObserver watching all tabs, notifying LoadTimeStats
-// whenever the spinner starts or stops for a given tab, and when a renderer
-// is no longer used.
-class LoadTimeStatsTabHelper : public content::WebContentsObserver {
+// A WebContentsObserver watching a tab, notifying LoadTimeStats whenever the
+// spinner starts or stops for it, and whenever a renderer is no longer used.
+class LoadTimeStatsTabHelper
+ : public content::WebContentsObserver,
+ public WebContentsUserData<LoadTimeStatsTabHelper> {
public:
- explicit LoadTimeStatsTabHelper(TabContents* tab);
virtual ~LoadTimeStatsTabHelper();
// content::WebContentsObserver implementation
@@ -137,10 +136,14 @@ class LoadTimeStatsTabHelper : public content::WebContentsObserver {
content::RenderViewHost* render_view_host) OVERRIDE;
private:
+ explicit LoadTimeStatsTabHelper(content::WebContents* web_contents);
+ static int kUserDataKey;
+ friend class WebContentsUserData<LoadTimeStatsTabHelper>;
+
// Calls into LoadTimeStats to notify that a reportable event has occurred
// for the tab being observed.
void NotifyLoadTimeStats(LoadTimeStats::TabEvent event,
- content::RenderViewHost* render_view_host);
+ content::RenderViewHost* render_view_host);
bool is_otr_profile_;
« no previous file with comments | « no previous file | chrome/browser/net/load_time_stats.cc » ('j') | chrome/browser/net/load_time_stats.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698