Switch LoadTimeStatsTabHelper to use WebContentsUserData.

chrome/browser/net/load_time_stats.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/net/load_time_stats.h"
 
 #include "base/metrics/histogram.h"
 #include "base/stl_util.h"
 #include "base/string_number_conversions.h"
 #include "base/timer.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/io_thread.h"
 #include "chrome/browser/profiles/profile.h"
-#include "chrome/browser/ui/tab_contents/tab_contents.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/resource_request_info.h"
 #include "content/public/browser/web_contents.h"
 #include "net/url_request/url_request.h"
 
 using content::BrowserThread;
 using content::RenderViewHost;
 using content::ResourceRequestInfo;
@@ skipping 223 matching lines @@
  private:
   base::TimeTicks GetCurrentTime() {
     return base::TimeTicks::Now();
   }
   bool done_;
   base::TimeTicks start_time_;
   RequestStatus status_;
   base::TimeDelta status_times_[REQUEST_STATUS_MAX];
 };
 
-LoadTimeStatsTabHelper::LoadTimeStatsTabHelper(TabContents* tab)
-    : content::WebContentsObserver(tab->web_contents()) {
-  is_otr_profile_ = tab->profile()->IsOffTheRecord();
+int LoadTimeStatsTabHelper::kUserDataKey;

[cbentzel, 2012/09/18 13:55:41]

Nit: // static comment? 

Also - would it make sense to explain that the value doesn't matter, or is this
such an idiom for WebContentsUserData that it isn't needed at each key site.

[Avi (use Gerrit), 2012/09/18 14:11:47]

This is an idiom; every WebContentsUserData gets one :/

+
+LoadTimeStatsTabHelper::LoadTimeStatsTabHelper(
+    content::WebContents* web_contents)
+    : content::WebContentsObserver(web_contents) {
+  is_otr_profile_ = web_contents->GetBrowserContext()->IsOffTheRecord();
 }
 
 LoadTimeStatsTabHelper::~LoadTimeStatsTabHelper() {
 }
 
 void LoadTimeStatsTabHelper::DidStartProvisionalLoadForFrame(
     int64 frame_id,
     bool is_main_frame,
     const GURL& validated_url,
     bool is_error_page,
@@ skipping 273 matching lines @@
   if (type == ChromeURLRequestContext::CONTEXT_TYPE_MAIN)
     main_request_contexts_.insert(context);
 }
 
 void LoadTimeStats::UnregisterURLRequestContext(
     const net::URLRequestContext* context) {
   main_request_contexts_.erase(context);
 }
 
 }  // namespace chrome_browser_net