Re-do the way browser windows are shown:...

Re-do the way browser windows are shown:

- Remove the path from WinMain to the Browser object passing the show_command. For the Browser object, this is a problem since this value isn't portable. For the code in general it involves a lot of ugly wiring. It's completely unnecessary since the value is obtainable via GetStartupInfo.
- Remove show_command plumbing from all over the place (session restore, web app launcher, etc)

Change the way browser windows are constructed:
- The browser constructor now takes just a type and a profile, and simply initializes the object.
- Some configuration that used to be part of the constructor that was only used in one or two use cases (initial bounds, maximized state, web app name) are split into separate setters.
- Window creation is split out into a separate step to be called post configuration.
- Assorted static helper functions added to Browser to make construction of common types easy.
- Remove Browser::Show in favor of BrowserWindow::Show
- Adjust all callers to use the new helpers.

Change the way ChromeViews restores window placement:
- Split restored size determination from restored maximized determination. They are needed by the code at different times. Size restoration happens when the window is constructed and Window::SetInitialBounds is called. Maximized state restoration happens when the window is shown for the first time and SW_SHOWMAXIMIZED or SW_SHOWNORMAL is needed. Thus, replace WindowDelegate::RestoreWindowPosition with WindowDelegate::RestoreWindowBounds and WindowDelegate::RestoreMaximizedState.
- Window::SetInitialBounds calls WindowDelegate::RestoreWindowBounds
- Window::Show calls WindowDelegate::RestoreMaximizedState
- Adjusts all WindowDelegate implementations that override RestoreWindowPosition to implement these new methods instead.
- Move "playback/record" mode window size setting from browser_init to Browser::RestoreWindowBounds.
- Provide a virtual function on Window called GetShowState that determines the default show state to be used when Window::Show is called. For most windows and dialogs this is SW_SHOWNORMAL. AeroGlassFrame/OpaqueFrame (the browser window frames) override this since they're the app's main windows to return the value provided by GetStartupInfo which gives the value from the app shortcut.

http://crbug.com/3557


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=5417

[sky, 2008-11-13 21:44:08]

http://codereview.chromium.org/10896/diff/1/33
File chrome/browser/browser.cc (right):

http://codereview.chromium.org/10896/diff/1/33#newcode248
Line 248: window_ = BrowserWindow::CreateBrowserWindow(this);
How about a DCHECK(!window_) here.

http://codereview.chromium.org/10896/diff/1/9
File chrome/browser/browser.h (right):

http://codereview.chromium.org/10896/diff/1/9#newcode39
Line 39: // Creates a new browser with the given bounds. If the bounds are
empty, the
nit: remove comments about bounds.

http://codereview.chromium.org/10896/diff/1/9#newcode109
Line 109: bool RestoreMaximizedState() const;
These names make it sound like they take action, but they don't. How about
prefixing them with Get.

http://codereview.chromium.org/10896/diff/1/16
File chrome/browser/views/frame/browser_view.cc (right):

http://codereview.chromium.org/10896/diff/1/16#newcode127
Line 127: STARTUPINFO si;
set this to {0} to make sure everything is reset.

http://codereview.chromium.org/10896/diff/1/40
File chrome/views/window.cc (right):

http://codereview.chromium.org/10896/diff/1/40#newcode557
Line 557: AlwaysOnTopChanged();
nit: spacing

http://codereview.chromium.org/10896/diff/1/41
File chrome/views/window_delegate.h (right):

http://codereview.chromium.org/10896/diff/1/41#newcode111
Line 111: virtual bool RestoreWindowBounds(gfx::Rect* bounds) const {
Same comment about naming these GetXXX.

[sky, 2008-11-14 00:28:09]

LGTM

Nice cleanup!

http://codereview.chromium.org/10896/diff/203/136
File chrome/views/window_delegate.cc (right):

http://codereview.chromium.org/10896/diff/203/136#newcode80
Line 80: g_browser_process->local_state()->GetDictionary(window_name.c_str());
nit: 4 spaces.