Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: chrome/browser/bookmarks/bookmark_utils.cc

Issue 10896: Re-do the way browser windows are shown:... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/bookmarks/bookmark_utils.cc
===================================================================
--- chrome/browser/bookmarks/bookmark_utils.cc (revision 5374)
+++ chrome/browser/bookmarks/bookmark_utils.cc (working copy)
@@ -35,7 +35,7 @@
virtual ~NewBrowserPageNavigator() {
if (browser_)
- browser_->Show();
+ browser_->window()->Show();
}
Browser* browser() const { return browser_; }
@@ -47,8 +47,7 @@
if (!browser_) {
Profile* profile = (disposition == OFF_THE_RECORD) ?
profile_->GetOffTheRecordProfile() : profile_;
- browser_ = new Browser(gfx::Rect(), SW_SHOW, profile,
- BrowserType::TABBED_BROWSER, std::wstring());
+ browser_ = Browser::Create(profile);
// Always open the first tab in the foreground.
disposition = NEW_FOREGROUND_TAB;
}

Powered by Google App Engine
This is Rietveld 408576698