Re-do the way browser windows are shown:...

chrome/browser/views/page_info_window.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/views/page_info_window.h"
 
 #include <cryptuiapi.h>
 #pragma comment(lib, "cryptui.lib")
 
 #include "base/string_util.h"
@@ skipping 536 matching lines @@
   layout->StartRow(1, 0);
   layout->AddView(CreateSecurityTabView(profile, url, ssl, page_type,
                                         show_history), 2, 1);
 
   layout->AddPaddingRow(0, kHorizontalPadding);
 
   if (opened_window_count_ > 0) {
     // There already is a PageInfo window opened.  Let's shift the location of
     // the new PageInfo window so they don't overlap entirely.
     // Window::Init will position the window from the stored location.
-    CRect bounds;
-    bool maximized, always_on_top;
-    if (RestoreWindowPosition(&bounds, &maximized, &always_on_top)) {
-      CalculateWindowBounds(&bounds);
-      SaveWindowPosition(bounds, maximized, always_on_top);
+    gfx::Rect bounds;
+    bool maximized = false;
+    if (GetSavedWindowBounds(&bounds) && GetSavedMaximizedState(&maximized)) {
+      CRect bounds_crect(bounds.ToRECT());
+      CalculateWindowBounds(&bounds_crect);
+      SaveWindowPlacement(gfx::Rect(bounds_crect), maximized, false);
     }
   }
 
   views::Window::CreateChromeWindow(parent, gfx::Rect(), this);
   // TODO(beng): (Cleanup) - cert viewer button should use GetExtraView.
   
   if (cert_id_) {
     scoped_refptr<net::X509Certificate> cert;
     CertStore::GetSharedInstance()->RetrieveCert(cert_id_, &cert);
     // When running with Gears, we have no os certificate, so there is no cert
@@ skipping 25 matching lines @@
 }
 
 int PageInfoWindow::GetDialogButtons() const {
   return DIALOGBUTTON_CANCEL;
 }
 
 std::wstring PageInfoWindow::GetWindowTitle() const {
   return l10n_util::GetString(IDS_PAGEINFO_WINDOW_TITLE);
 }
 
-void PageInfoWindow::SaveWindowPosition(const CRect& bounds,
-                                        bool maximized,
-                                        bool always_on_top) {
-  window()->SaveWindowPositionToPrefService(g_browser_process->local_state(),
-                                            prefs::kPageInfoWindowPlacement,
-                                            bounds, maximized, always_on_top);
-}
-
-bool PageInfoWindow::RestoreWindowPosition(CRect* bounds,
-                                           bool* maximized,
-                                           bool* always_on_top) {
-  bool restore = window()->RestoreWindowPositionFromPrefService(
-      g_browser_process->local_state(),
-      prefs::kPageInfoWindowPlacement,
-      bounds, maximized, always_on_top);
-
-  if (restore) {
-    // Force the correct width and height in case we've changed it
-    // or the pref got messed up (we know that some users will have
-    // the wrong preference if they ran into bug 3509). This isn't 
-    // a resizable dialog, so overriding the saved width and height
-    // shouldn't be noticable.
-    gfx::Size size = contents_->GetPreferredSize();
-    bounds->right = bounds->left + size.width();
-    bounds->bottom = bounds->top + size.height();
-  }
-
-  return restore;
+std::wstring PageInfoWindow::GetWindowName() const {
+  return prefs::kPageInfoWindowPlacement;
 }
 
 views::View* PageInfoWindow::GetContentsView() {
   return contents_;
 }
 
 void PageInfoWindow::ButtonPressed(views::NativeButton* sender) {
   if (sender == cert_info_button_) {
     DCHECK(cert_id_ != 0);
     ShowCertDialog(cert_id_);
@@ skipping 58 matching lines @@
   HCERTSTORE cert_store = view_info.pCertContext->hCertStore;
   view_info.cStores = 1;
   view_info.rghStores = &cert_store;
   BOOL properties_changed;
 
   // This next call blocks but keeps processing windows messages, making it
   // modal to the browser window.
   BOOL rv = ::CryptUIDlgViewCertificate(&view_info, &properties_changed);
 }