Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/views/options/advanced_contents_view.cc

Issue 10896: Re-do the way browser windows are shown:... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/views/frame/opaque_non_client_view.cc ('k') | chrome/browser/views/page_info_window.h » ('j') | chrome/views/window_delegate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/options/advanced_contents_view.cc
===================================================================
--- chrome/browser/views/options/advanced_contents_view.cc (revision 5374)
+++ chrome/browser/views/options/advanced_contents_view.cc (working copy)
@@ -443,14 +443,9 @@
if (source == learn_more_link_) {
// We open a new browser window so the Options dialog doesn't get lost
// behind other windows.
- Browser* browser = new Browser(gfx::Rect(), SW_SHOWNORMAL, profile(),
- BrowserType::TABBED_BROWSER,
- std::wstring());
- browser->OpenURL(
- GURL(l10n_util::GetString(IDS_LEARN_MORE_PRIVACY_URL)),
- GURL(),
- NEW_WINDOW,
- PageTransition::LINK);
+ Browser* browser = Browser::Create(profile());
+ browser->OpenURL(GURL(l10n_util::GetString(IDS_LEARN_MORE_PRIVACY_URL)),
+ GURL(), NEW_WINDOW, PageTransition::LINK);
}
}
« no previous file with comments | « chrome/browser/views/frame/opaque_non_client_view.cc ('k') | chrome/browser/views/page_info_window.h » ('j') | chrome/views/window_delegate.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698