Set linux distro to CHROMEOS_RELEASE_DESCRIPTION on ChromeOS

Set linux distro to CHROMEOS_RELEASE_DESCRIPTION on ChromeOS

This makes ChromeOS more consistent with Linux, which uses the DISTRIB_DESCRIPTION from /etc/lsb-release here.  We have a different pre-existing mechanism in the code for reading the value (since ChromeOS doesn't have the lsb_release tool), but it's conceptually the same thing.

This makes it possible to search / catagorize ChromeOS crash reports based on the build, or other information about the ChromeOS version.  It also allows the matching build/symbols to be more easily found given a crash report.

There's no need for Aura customization of distro anymore - that was added when
Aura was experimental.  All ChromeOS is now Aura.

BUG=142630
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151741

[Rick Byers, 2012-08-14 19:32:53]

Hey Brett,
Can you please review this little change to improve our crash reporting on
ChromeOS?

Thanks,
   Rick

[brettw, 2012-08-14 19:42:32]

lgtm

http://codereview.chromium.org/10827322/diff/1/chrome/browser/chrome_browser_...
File chrome/browser/chrome_browser_main_linux.cc (right):

http://codereview.chromium.org/10827322/diff/1/chrome/browser/chrome_browser_...
chrome/browser/chrome_browser_main_linux.cc:35: std::string version)
Can you make this a const ref? I know you didn't add this but if it's easy it
seems nice to fix now.

http://codereview.chromium.org/10827322/diff/1/chrome/browser/chrome_browser_...
chrome/browser/chrome_browser_main_linux.cc:36: {
Check { placement.

http://codereview.chromium.org/10827322/diff/1/chrome/browser/chrome_browser_...
File chrome/browser/chrome_browser_main_linux.h (right):

http://codereview.chromium.org/10827322/diff/1/chrome/browser/chrome_browser_...
chrome/browser/chrome_browser_main_linux.h:15: #include
"chrome/browser/cancelable_request.h"
I usually recommend only putting includes in an ifdef if they don't compile, so
I'd put this cancelable_request one in the previous section.

[Rick Byers, 2012-08-14 20:07:00]

Thanks for the quick response!

http://codereview.chromium.org/10827322/diff/1/chrome/browser/chrome_browser_...
File chrome/browser/chrome_browser_main_linux.cc (right):

http://codereview.chromium.org/10827322/diff/1/chrome/browser/chrome_browser_...
chrome/browser/chrome_browser_main_linux.cc:35: std::string version)
On 2012/08/14 19:42:32, brettw wrote:
> Can you make this a const ref? I know you didn't add this but if it's easy it
> seems nice to fix now.

I don't think so.  CancelableRequest dispatches the response back to the
original requesting thread, so we have to copy the string by value.  Or am I
missing something?

Of course in this case that seems like overkill - I think I could have safely
called SetLinuxDistro from the FILE thread and avoided posting back to the main
thread.  But I think it's better to be consistent across all the places we read
this version info, and certainly in the WebUI cases we need to get back to the
right thread.  This does seem like an awefull lot of machinery for something
that should be pretty simple though...

http://codereview.chromium.org/10827322/diff/1/chrome/browser/chrome_browser_...
chrome/browser/chrome_browser_main_linux.cc:36: {
On 2012/08/14 19:42:32, brettw wrote:
> Check { placement.

Done.

http://codereview.chromium.org/10827322/diff/1/chrome/browser/chrome_browser_...
File chrome/browser/chrome_browser_main_linux.h (right):

http://codereview.chromium.org/10827322/diff/1/chrome/browser/chrome_browser_...
chrome/browser/chrome_browser_main_linux.h:15: #include
"chrome/browser/cancelable_request.h"
On 2012/08/14 19:42:32, brettw wrote:
> I usually recommend only putting includes in an ifdef if they don't compile,
so
> I'd put this cancelable_request one in the previous section.

Done.

[brettw, 2012-08-14 20:08:52]

http://codereview.chromium.org/10827322/diff/1/chrome/browser/chrome_browser_...
File chrome/browser/chrome_browser_main_linux.cc (right):

http://codereview.chromium.org/10827322/diff/1/chrome/browser/chrome_browser_...
chrome/browser/chrome_browser_main_linux.cc:35: std::string version)
Bind should know to copy const ref args.

[Rick Byers, 2012-08-15 14:39:33]

On 2012/08/14 20:08:52, brettw wrote:
>
http://codereview.chromium.org/10827322/diff/1/chrome/browser/chrome_browser_...
> File chrome/browser/chrome_browser_main_linux.cc (right):
> 
>
http://codereview.chromium.org/10827322/diff/1/chrome/browser/chrome_browser_...
> chrome/browser/chrome_browser_main_linux.cc:35: std::string version)
> Bind should know to copy const ref args.

Cool, sorry I missed that.  Done.

[commit-bot: I haz the power, 2012-08-15 18:09:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rbyers@chromium.org/10827322/9001

[commit-bot: I haz the power, 2012-08-15 20:54:10]

Change committed as 151741