chrome/browser/ui/webui/help/help_handler.h - Issue 10827322: Set linux distro to CHROMEOS_RELEASE_DESCRIPTION on ChromeOS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/help/help_handler.h

Issue 10827322: Set linux distro to CHROMEOS_RELEASE_DESCRIPTION on ChromeOS (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merge with trunk and switch to const-ref string params in version loader callbacks Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/help/help_handler.h

diff --git a/chrome/browser/ui/webui/help/help_handler.h b/chrome/browser/ui/webui/help/help_handler.h

index b662f7ac2600b050e5b22c4b0c812b25f8ae043f..2d5bef7249ad4987b5a25db456344b2862d9e16c 100644

--- a/chrome/browser/ui/webui/help/help_handler.h

+++ b/chrome/browser/ui/webui/help/help_handler.h

@@ -70,9 +70,10 @@ class HelpHandler : public content::WebUIMessageHandler,

#if defined(OS_CHROMEOS)

// Callbacks from VersionLoader.

- void OnOSVersion(chromeos::VersionLoader::Handle handle, std::string version);

+ void OnOSVersion(chromeos::VersionLoader::Handle handle,

+ const std::string& version);

void OnOSFirmware(chromeos::VersionLoader::Handle handle,

- std::string firmware);

+ const std::string& firmware);

void OnReleaseChannel(const std::string& channel);

void ProcessLsbFileInfo(