chrome/browser/ui/webui/about_ui.cc - Issue 10827322: Set linux distro to CHROMEOS_RELEASE_DESCRIPTION on ChromeOS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/about_ui.cc

Issue 10827322: Set linux distro to CHROMEOS_RELEASE_DESCRIPTION on ChromeOS (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merge with trunk and switch to const-ref string params in version loader callbacks Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/about_ui.cc

diff --git a/chrome/browser/ui/webui/about_ui.cc b/chrome/browser/ui/webui/about_ui.cc

index 6897cba2a6f8980fe6a20eac64926a9571b86182..73460ad231f1ae67de9b2523942fa995925ad66b 100644

--- a/chrome/browser/ui/webui/about_ui.cc

+++ b/chrome/browser/ui/webui/about_ui.cc

@@ -162,7 +162,7 @@ class ChromeOSAboutVersionHandler {

// Callback from chromeos::VersionLoader giving the version.

void OnVersion(chromeos::VersionLoader::Handle handle,

- std::string version);

+ const std::string& version);

private:

// Where the results are fed to.

@@ -1276,7 +1276,7 @@ ChromeOSAboutVersionHandler::ChromeOSAboutVersionHandler(

void ChromeOSAboutVersionHandler::OnVersion(

chromeos::VersionLoader::Handle handle,

- std::string version) {

+ const std::string& version) {

DictionaryValue localized_strings;

localized_strings.SetString("os_version", version);

source_->FinishDataRequest(AboutVersionStrings(