chrome/browser/policy/device_status_collector.h - Issue 10827322: Set linux distro to CHROMEOS_RELEASE_DESCRIPTION on ChromeOS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/device_status_collector.h

Issue 10827322: Set linux distro to CHROMEOS_RELEASE_DESCRIPTION on ChromeOS (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merge with trunk and switch to const-ref string params in version loader callbacks Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/policy/device_status_collector.h

diff --git a/chrome/browser/policy/device_status_collector.h b/chrome/browser/policy/device_status_collector.h

index f5b2599cde46b1bd487731824b8874df6d90a1a0..744db3f290e7117b822e750518ca672201ef61af 100644

--- a/chrome/browser/policy/device_status_collector.h

+++ b/chrome/browser/policy/device_status_collector.h

@@ -87,9 +87,9 @@ class DeviceStatusCollector : public content::NotificationObserver {

// Callbacks from chromeos::VersionLoader.

void OnOSVersion(chromeos::VersionLoader::Handle handle,

- std::string version);

+ const std::string& version);

void OnOSFirmware(chromeos::VersionLoader::Handle handle,

- std::string version);

+ const std::string& version);

// Helpers for the various portions of the status.

void GetActivityTimes(