Issue 10761: Rewire the throbber so that the timer for updating lives on BrowserView, not ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10761: Rewire the throbber so that the timer for updating lives on BrowserView, not ... (Closed)

Created:
12 years, 1 month ago by Ben Goodger (Google)

Modified:
9 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Rewire the throbber so that the timer for updating lives on BrowserView, not TabStrip, so that app window/popup throbber updating doesn't need to be plumbed through the tabstrip and the browser object! http://crbug.com/3297 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=5513

Patch Set 1 #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+69 lines, -90 lines)			Patch
M	chrome/browser/browser.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/browser.cc	View	3 chunks	+5 lines, -8 lines	1 comment	Download
M	chrome/browser/browser_window.h	View	1 chunk	+4 lines, -5 lines	1 comment	Download
M	chrome/browser/tabs/tab_strip_model.h	View	3 chunks	+0 lines, -16 lines	0 comments	Download
M	chrome/browser/tabs/tab_strip_model.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/tabs/tab_strip_model_unittest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/views/frame/browser_view.h	View	3 chunks	+7 lines, -1 line	0 comments	Download
M	chrome/browser/views/frame/browser_view.cc	View	5 chunks	+29 lines, -4 lines	1 comment	Download
M	chrome/browser/views/tabs/tab_strip.h	View	4 chunks	+3 lines, -7 lines	0 comments	Download
M	chrome/browser/views/tabs/tab_strip.cc	View	4 chunks	+18 lines, -42 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sky

12 years, 1 month ago (2008-11-14 22:07:21 UTC) #2

Just a couple of minor things, LGTM otherwise

http://codereview.chromium.org/10761/diff/1/8
File chrome/browser/browser.cc (right):

http://codereview.chromium.org/10761/diff/1/8#newcode398
Line 398: return GetSelectedTabContents()->is_loading();
Should no null check this?

http://codereview.chromium.org/10761/diff/1/7
File chrome/browser/browser_window.h (right):

http://codereview.chromium.org/10761/diff/1/7#newcode74
Line 74: // Update any loading animations running in the window. |loading| is
true if
nit: loading -> should_animate

http://codereview.chromium.org/10761/diff/1/5
File chrome/browser/views/frame/browser_view.cc (right):

http://codereview.chromium.org/10761/diff/1/5#newcode429
Line 429: TimeDelta::FromMilliseconds(kLoadingAnimationFrameTimeMs), this,
nit: 4 space indent

Expand Messages | Collapse Messages