Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5381)

Unified Diff: chrome/browser/views/frame/browser_view.h

Issue 10761: Rewire the throbber so that the timer for updating lives on BrowserView, not ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/views/frame/browser_view.h
===================================================================
--- chrome/browser/views/frame/browser_view.h (revision 5492)
+++ chrome/browser/views/frame/browser_view.h (working copy)
@@ -151,7 +151,7 @@
virtual StatusBubble* GetStatusBubble();
virtual void SelectedTabToolbarSizeChanged(bool is_animating);
virtual void UpdateTitleBar();
- virtual void ValidateThrobber();
+ virtual void UpdateLoadingAnimations(bool should_animate);
virtual gfx::Rect GetNormalBounds() const;
virtual bool IsMaximized();
virtual ToolbarStarToggle* GetStarButton() const;
@@ -308,6 +308,9 @@
// Retrieves the command id for the specified Windows app command.
int GetCommandIDForAppCommandID(int app_command_id) const;
+ // Callback for the loading animation(s) associated with this view.
+ void LoadingAnimationCallback();
+
// Initialize the hung plugin detector.
void InitHangMonitor();
@@ -385,6 +388,9 @@
// plugin window.
HungPluginAction hung_plugin_action_;
+ // The timer used to update frames for the Loading Animation.
+ base::RepeatingTimer<BrowserView> loading_animation_timer_;
+
// P13N stuff
#ifdef CHROME_PERSONALIZATION
FramePersonalization personalization_;

Powered by Google App Engine
This is Rietveld 408576698