Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3998)

Unified Diff: chrome/browser/tabs/tab_strip_model.h

Issue 10761: Rewire the throbber so that the timer for updating lives on BrowserView, not ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/tabs/tab_strip_model.h
===================================================================
--- chrome/browser/tabs/tab_strip_model.h (revision 5492)
+++ chrome/browser/tabs/tab_strip_model.h (working copy)
@@ -69,12 +69,6 @@
int to_index) { }
// The specified TabContents at |index| changed in some way.
virtual void TabChangedAt(TabContents* contents, int index) { }
- // Loading progress representations for tabs should be validated/updated.
- // TODO(beng): this wiring is cracktarded. consider revising. The loading
- // animation timer should live in BrowserView2, and from there
- // notify both the tabstrip and the window icon.
- // clean this up once XPFrame and VistaFrame have retired.
- virtual void TabValidateAnimations() { }
// The TabStripModel now no longer has any "significant" (user created or
// user manipulated) tabs. The implementer may use this as a trigger to try
// and close the window containing the TabStripModel, for example...
@@ -131,11 +125,6 @@
// window.
virtual void DuplicateContentsAt(int index) = 0;
- // Called every time the the throbber needs to be updated. We have this to
- // give the browser/frame a chance to implement some loading animation. This
- // is used by simple web application frames.
- virtual void ValidateLoadingAnimations() = 0;
-
// Called when a drag session has completed and the frame that initiated the
// the session should be closed.
virtual void CloseFrameAfterDragSession() = 0;
@@ -280,11 +269,6 @@
// changed in some way.
void UpdateTabContentsStateAt(int index);
- // Notify any observers that Loading progress for TabContents should be
- // validated.
- // TODO(beng): (Cleanup) This should definitely be moved to the View.
- void UpdateTabContentsLoadingAnimations();
-
// Make sure there is an auto-generated New Tab tab in the TabStripModel.
// If |force_create| is true, the New Tab will be created even if the
// preference is set to false (used by startup).

Powered by Google App Engine
This is Rietveld 408576698