Rewire the throbber so that the timer for updating lives on BrowserView, not ...

chrome/browser/tabs/tab_strip_model.h

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_TABS_TAB_STRIP_MODEL_H__
 #define CHROME_BROWSER_TABS_TAB_STRIP_MODEL_H__
 
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 51 matching lines @@
   virtual void TabSelectedAt(TabContents* old_contents,
                              TabContents* new_contents,
                              int index,
                              bool user_gesture) { }
   // The specified TabContents at |from_index| was moved to |to_index|.
   virtual void TabMoved(TabContents* contents,
                         int from_index,
                         int to_index) { }
   // The specified TabContents at |index| changed in some way.
   virtual void TabChangedAt(TabContents* contents, int index) { }
-  // Loading progress representations for tabs should be validated/updated.
-  // TODO(beng): this wiring is cracktarded. consider revising. The loading
-  //             animation timer should live in BrowserView2, and from there
-  //             notify both the tabstrip and the window icon.
-  //             clean this up once XPFrame and VistaFrame have retired.
-  virtual void TabValidateAnimations() { }
   // The TabStripModel now no longer has any "significant" (user created or
   // user manipulated) tabs. The implementer may use this as a trigger to try
   // and close the window containing the TabStripModel, for example...
   virtual void TabStripEmpty() { }
 };
 
 ///////////////////////////////////////////////////////////////////////////////
 //
 // TabStripModelDelegate
 //
@@ skipping 36 matching lines @@
       bool defer_load,
       SiteInstance* instance) const = 0;
 
   // Return whether some contents can be duplicated.
   virtual bool CanDuplicateContentsAt(int index) = 0;
 
   // Duplicate the contents at the provided index and places it into its own
   // window.
   virtual void DuplicateContentsAt(int index) = 0;
 
-  // Called every time the the throbber needs to be updated. We have this to
-  // give the browser/frame a chance to implement some loading animation. This
-  // is used by simple web application frames.
-  virtual void ValidateLoadingAnimations() = 0;
-
   // Called when a drag session has completed and the frame that initiated the
   // the session should be closed.
   virtual void CloseFrameAfterDragSession() = 0;
 };
 
 ////////////////////////////////////////////////////////////////////////////////
 //
 // TabStripModel
 //
 //  A model & low level controller of a Browser Window tabstrip. Holds a vector
@@ skipping 124 matching lines @@
   int GetIndexOfTabContents(const TabContents* contents) const;
 
   // Returns the index of the specified NavigationController, or -1 if it is
   // not in this TabStripModel.
   int GetIndexOfController(const NavigationController* controller) const;
 
   // Notify any observers that the TabContents at the specified index has
   // changed in some way.
   void UpdateTabContentsStateAt(int index);
 
-  // Notify any observers that Loading progress for TabContents should be
-  // validated.
-  // TODO(beng): (Cleanup) This should definitely be moved to the View.
-  void UpdateTabContentsLoadingAnimations();
-
   // Make sure there is an auto-generated New Tab tab in the TabStripModel.
   // If |force_create| is true, the New Tab will be created even if the
   // preference is set to false (used by startup).
   void EnsureNewTabVisible(bool force_create);
 
   // Close all tabs at once. Code can use closing_all() above to defer
   // operations that might otherwise by invoked by the flurry of detach/select
   // notifications this method causes.
   void CloseAllTabs();
 
@@ skipping 229 matching lines @@
 
   // Our observers.
   typedef ObserverList<TabStripModelObserver> TabStripModelObservers;
   TabStripModelObservers observers_;
 
   DISALLOW_EVIL_CONSTRUCTORS(TabStripModel);
 };
 
 #endif  // CHROME_BROWSER_TABS_TAB_STRIP_MODEL_H__