chrome/browser/extensions/api/api_resource_event_notifier.cc - Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/api_resource_event_notifier.cc

Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase and review changes. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/alarms/alarm_manager.cc ('K') | « chrome/browser/extensions/api/alarms/alarm_manager.cc ('k') | chrome/browser/extensions/api/app/app_api.cc » ('j') | chrome/browser/extensions/api/downloads/downloads_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/api_resource_event_notifier.cc

diff --git a/chrome/browser/extensions/api/api_resource_event_notifier.cc b/chrome/browser/extensions/api/api_resource_event_notifier.cc

index c89aa0055e849a12f9b4ece0b613bd0e7184c20d..c72b865b99b170bc6030244ae42ef01e51607e9b 100644

--- a/chrome/browser/extensions/api/api_resource_event_notifier.cc

+++ b/chrome/browser/extensions/api/api_resource_event_notifier.cc

@@ -134,9 +134,9 @@ void APIResourceEventNotifier::DispatchEventOnUIThread(

const std::string &extension, DictionaryValue* event) {

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

- ListValue args;

- args.Set(0, event);

- router_->DispatchEventToExtension(src_extension_id_, extension, args,

+ ListValue* const arguments = new ListValue();

miket_OOO 2012/07/10 22:33:19 For future grep/sed/readability sanity, can you ch

+ arguments->Set(0, event);

+ router_->DispatchEventToExtension(src_extension_id_, extension, arguments,

profile_, src_url_);

}