chrome/browser/extensions/api/alarms/alarm_manager.cc - Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/alarms/alarm_manager.cc

Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase and review changes. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/bookmarks/bookmark_manager_extension_api.cc ('K') | « chrome/browser/chromeos/extensions/file_handler_util.cc ('k') | chrome/browser/extensions/api/api_resource_event_notifier.cc » ('j') | chrome/browser/extensions/api/api_resource_event_notifier.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/alarms/alarm_manager.cc

diff --git a/chrome/browser/extensions/api/alarms/alarm_manager.cc b/chrome/browser/extensions/api/alarms/alarm_manager.cc

index cf0e31a16795fa59ddbc5872c39c91c6f1cae102..a2e94579b6bb419dec19082bc5812bce3e1b70df 100644

--- a/chrome/browser/extensions/api/alarms/alarm_manager.cc

+++ b/chrome/browser/extensions/api/alarms/alarm_manager.cc

@@ -38,12 +38,10 @@ class DefaultAlarmDelegate : public AlarmManager::Delegate {

virtual void OnAlarm(const std::string& extension_id,

const Alarm& alarm) {

- ListValue args;

- std::string json_args;

- args.Append(alarm.js_alarm->ToValue().release());

- base::JSONWriter::Write(&args, &json_args);

+ ListValue* args = new ListValue();

+ args->Append(alarm.js_alarm->ToValue().release());

ExtensionSystem::Get(profile_)->event_router()->DispatchEventToExtension(

miket_OOO 2012/07/10 22:33:19 I'm guessing I'll see later on how DispatchEventTo

- extension_id, kOnAlarmEvent, json_args, NULL, GURL());

+ extension_id, kOnAlarmEvent, args, NULL, GURL());

}

private: