chrome/browser/extensions/api/downloads/downloads_api.cc - Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api.cc

Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase and review changes. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/api_resource_event_notifier.cc ('K') | « chrome/browser/extensions/api/cookies/cookies_api.cc ('k') | chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc » ('j') | chrome/browser/extensions/api/web_navigation/web_navigation_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/downloads/downloads_api.cc

diff --git a/chrome/browser/extensions/api/downloads/downloads_api.cc b/chrome/browser/extensions/api/downloads/downloads_api.cc

index 49e8f77f553440ca3f2a4d7be78c38cf922222d9..d340dabdc42e3109f9cbe20d80b91e7be4147f42 100644

--- a/chrome/browser/extensions/api/downloads/downloads_api.cc

+++ b/chrome/browser/extensions/api/downloads/downloads_api.cc

@@ -1082,13 +1082,14 @@ void ExtensionDownloadsEventRouter::ManagerGoingDown(

void ExtensionDownloadsEventRouter::DispatchEvent(

const char* event_name, base::Value* arg) {

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

- base::ListValue args;

- args.Append(arg);

+ base::ListValue* args = new base::ListValue();

+ args->Append(arg);

std::string json_args;

- base::JSONWriter::Write(&args, &json_args);

+ base::JSONWriter::Write(args, &json_args);

profile_->GetExtensionEventRouter()->DispatchEventToRenderers(

miket_OOO 2012/07/10 22:33:19 Similar comment about future understanding of owne

event_name,

- json_args,

+ args,

profile_,

GURL(),

extensions::EventFilteringInfo());