Refactor extension event distribution to use Values instead of JSON strings.

chrome/browser/extensions/api/api_resource_event_notifier.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/api_resource_event_notifier.h"
 
 #include "base/bind.h"
 #include "base/json/json_writer.h"
 #include "base/values.h"
 #include "chrome/browser/extensions/extension_event_router.h"
@@ skipping 116 matching lines @@
       BrowserThread::UI, FROM_HERE,
       base::Bind(
           &APIResourceEventNotifier::DispatchEventOnUIThread, this, extension,
           event));
 }
 
 void APIResourceEventNotifier::DispatchEventOnUIThread(
     const std::string &extension, DictionaryValue* event) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
-  ListValue args;
-  args.Set(0, event);
-  router_->DispatchEventToExtension(src_extension_id_, extension, args,
+  ListValue* const arguments = new ListValue();

[miket_OOO, 2012/07/10 22:33:19]

For future grep/sed/readability sanity, can you change this to args to match
prior usage?

+  arguments->Set(0, event);
+  router_->DispatchEventToExtension(src_extension_id_, extension, arguments,
                                     profile_, src_url_);
 }
 
 DictionaryValue* APIResourceEventNotifier::CreateAPIResourceEvent(
     APIResourceEventType event_type) {
   DictionaryValue* event = new DictionaryValue();
   event->SetString(kEventTypeKey, APIResourceEventTypeToString(event_type));
   event->SetInteger(kSrcIdKey, src_id_);
 
   // TODO(miket): Signal that it's OK to clean up onEvent listeners. This is
@@ skipping 11 matching lines @@
     int result_code) {
   if (src_id_ < 0)
     return;
 
   DictionaryValue* event = CreateAPIResourceEvent(event_type);
   event->SetInteger(kResultCodeKey, result_code);
   DispatchEvent(extension, event);
 }
 
 }  // namespace extensions