Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 10556020: Cleaned up the reader and writer create methods to return scoped_ptr. (Closed)

Created:
8 years, 6 months ago by kxing
Modified:
8 years, 6 months ago
Reviewers:
Sergey Ulanov, Wez, garykac
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Cleaned up the reader and writer create methods to return scoped_ptr. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142498

Patch Set 1 #

Total comments: 4

Patch Set 2 : Removed unnecessary code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -16 lines) Patch
M remoting/protocol/audio_writer.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/audio_writer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/protocol/connection_to_client.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/connection_to_host.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/video_reader.h View 2 chunks +3 lines, -2 lines 0 comments Download
M remoting/protocol/video_reader.cc View 1 chunk +8 lines, -5 lines 0 comments Download
M remoting/protocol/video_writer.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/video_writer.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
kxing
Cleaned up the code for AudioWriter, VideoReader, and VideoWriter.
8 years, 6 months ago (2012-06-15 20:37:39 UTC) #1
Sergey Ulanov
Thanks for fixing it. http://codereview.chromium.org/10556020/diff/1/remoting/protocol/connection_to_client.cc File remoting/protocol/connection_to_client.cc (right): http://codereview.chromium.org/10556020/diff/1/remoting/protocol/connection_to_client.cc#newcode119 remoting/protocol/connection_to_client.cc:119: video_writer_.reset(); You don't need to ...
8 years, 6 months ago (2012-06-15 20:41:43 UTC) #2
kxing
http://codereview.chromium.org/10556020/diff/1/remoting/protocol/connection_to_client.cc File remoting/protocol/connection_to_client.cc (right): http://codereview.chromium.org/10556020/diff/1/remoting/protocol/connection_to_client.cc#newcode119 remoting/protocol/connection_to_client.cc:119: video_writer_.reset(); On 2012/06/15 20:41:43, sergeyu wrote: > You don't ...
8 years, 6 months ago (2012-06-15 20:48:17 UTC) #3
Sergey Ulanov
lgtm
8 years, 6 months ago (2012-06-15 20:48:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kxing@chromium.org/10556020/10
8 years, 6 months ago (2012-06-15 20:53:18 UTC) #5
commit-bot: I haz the power
Change committed as 142498
8 years, 6 months ago (2012-06-15 22:23:14 UTC) #6
Wez
8 years, 6 months ago (2012-06-20 22:56:03 UTC) #7
Retrospective LGTM :)

Powered by Google App Engine
This is Rietveld 408576698