Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: remoting/protocol/video_reader.cc

Issue 10556020: Cleaned up the reader and writer create methods to return scoped_ptr. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removed unnecessary code Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/video_reader.h ('k') | remoting/protocol/video_writer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/video_reader.cc
diff --git a/remoting/protocol/video_reader.cc b/remoting/protocol/video_reader.cc
index db2cc25de91e3cce1e98ed2034a94c53ef140a33..adf7189d97ba428c5e2986afab86a12e66fb3f81 100644
--- a/remoting/protocol/video_reader.cc
+++ b/remoting/protocol/video_reader.cc
@@ -13,19 +13,22 @@ namespace protocol {
VideoReader::~VideoReader() { }
// static
-VideoReader* VideoReader::Create(const SessionConfig& config) {
+scoped_ptr<VideoReader> VideoReader::Create(const SessionConfig& config) {
const ChannelConfig& video_config = config.video_config();
if (video_config.transport == ChannelConfig::TRANSPORT_STREAM) {
if (video_config.codec == ChannelConfig::CODEC_VP8) {
- return new ProtobufVideoReader(VideoPacketFormat::ENCODING_VP8);
+ return scoped_ptr<VideoReader>(
+ new ProtobufVideoReader(VideoPacketFormat::ENCODING_VP8));
} else if (video_config.codec == ChannelConfig::CODEC_ZIP) {
- return new ProtobufVideoReader(VideoPacketFormat::ENCODING_ZLIB);
+ return scoped_ptr<VideoReader>(
+ new ProtobufVideoReader(VideoPacketFormat::ENCODING_ZLIB));
} else if (video_config.codec == ChannelConfig::CODEC_VERBATIM) {
- return new ProtobufVideoReader(VideoPacketFormat::ENCODING_VERBATIM);
+ return scoped_ptr<VideoReader>(
+ new ProtobufVideoReader(VideoPacketFormat::ENCODING_VERBATIM));
}
}
NOTREACHED();
- return NULL;
+ return scoped_ptr<VideoReader>(NULL);
}
} // namespace protocol
« no previous file with comments | « remoting/protocol/video_reader.h ('k') | remoting/protocol/video_writer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698