Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Unified Diff: remoting/protocol/video_reader.h

Issue 10556020: Cleaned up the reader and writer create methods to return scoped_ptr. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removed unnecessary code Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/connection_to_host.cc ('k') | remoting/protocol/video_reader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/video_reader.h
diff --git a/remoting/protocol/video_reader.h b/remoting/protocol/video_reader.h
index ef954416ff589ba973dc1cc2d7a1d66706d40f2a..63582cf73813401fe7ef415a49c812c42c89801f 100644
--- a/remoting/protocol/video_reader.h
+++ b/remoting/protocol/video_reader.h
@@ -10,6 +10,7 @@
#define REMOTING_PROTOCOL_VIDEO_READER_H_
#include "base/callback.h"
+#include "base/memory/scoped_ptr.h"
#include "remoting/protocol/video_stub.h"
namespace remoting {
@@ -20,14 +21,14 @@ class SessionConfig;
class VideoReader {
public:
- static VideoReader* Create(const SessionConfig& config);
-
// The callback is called when initialization is finished. The
// parameter is set to true on success.
typedef base::Callback<void(bool)> InitializedCallback;
virtual ~VideoReader();
+ static scoped_ptr<VideoReader> Create(const SessionConfig& config);
+
// Initializies the reader. Doesn't take ownership of either |connection|
// or |video_stub|.
virtual void Init(Session* session,
« no previous file with comments | « remoting/protocol/connection_to_host.cc ('k') | remoting/protocol/video_reader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698