Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 10447053: Converts remainder of ui and chrome/browser/ui/views/frame to use ImageSkia (Closed)

Created:
8 years, 7 months ago by pkotwicz
Modified:
8 years, 6 months ago
Reviewers:
msw, sky
CC:
chromium-reviews, jennb, sadrul, ben+watch_chromium.org, tfarina, Dmitry Titov, dcheng, msw+watch_chromium.org, jianli, rdsmith+dwatch_chromium.org, alicet1, Andrei
Visibility:
Public.

Description

Converts remainder of ui (except for ui/app_list) and chrome/browser/ui/views/frame to use ImageSkia Do conversion using the same sed script as for 10437006 Modified by hand afterwards: 1 chrome/browser/download/download_util.cc 2 chrome/browser/ui/panels/panel_browser_frame_view.cc 3 chrome/browser/ui/panels/panel_browser_frame_view.h 4 chrome/browser/ui/toolbar/wrench_menu_model.cc 5 chrome/browser/ui/views/ash/browser_non_client_frame_view_ash.cc 6 chrome/browser/ui/views/ash/browser_non_client_frame_view_ash.h 7 chrome/browser/ui/views/constrained_window_views.cc 8 chrome/browser/ui/views/frame/glass_browser_frame_view.cc 9 chrome/browser/ui/views/tab_icon_view.h 10 ui/base/dragdrop/drag_utils.h 11 ui/base/dragdrop/drag_utils_gtk.cc 12 ui/base/dragdrop/drag_utils_win.cc 13 ui/base/native_theme/native_theme_android.cc 14 ui/base/native_theme/native_theme_android.h 15 ui/base/native_theme/native_theme_base.cc 16 ui/base/native_theme/native_theme_base.h 17 ui/views/widget/native_widget_private.h 18 ui/views/window/frame_background.h 19 ui/views/window/window_resources.h Line wrapping and include fixes chrome/browser/ui/views/frame/app_panel_browser_frame_view.cc 1 chrome/browser/ui/views/frame/browser_view.cc 2 chrome/browser/ui/views/frame/opaque_browser_frame_view.cc 3 ui/base/dragdrop/drag_utils_aura.cc 4 ui/base/dragdrop/os_exchange_data_provider_aura.h 5 ui/base/native_theme/native_theme_aura.cc 6 ui/views/button_drag_utils.h 7 ui/views/painter.cc 8 ui/views/painter.h 9 ui/views/widget/native_widget_aura.cc 10 ui/views/widget/widget_delegate.h 11 ui/views/window/custom_frame_view.cc 12 ui/views/window/custom_frame_view.h Test=Compiles, Webkit layout tests fast/ pass Bug=124566 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139734

Patch Set 1 #

Patch Set 2 : Nicer diff #

Patch Set 3 : Nicer diff #

Patch Set 4 : Nicer diff #

Patch Set 5 : Fixed breakage on windows #

Patch Set 6 : #

Total comments: 1

Patch Set 7 : Sorted headers in modified files #

Total comments: 1

Patch Set 8 : #

Patch Set 9 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+452 lines, -414 lines) Patch
M chrome/browser/download/download_util.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_frame_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_browser_frame_view.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/ash/browser_non_client_frame_view_ash.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/ash/browser_non_client_frame_view_ash.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/constrained_window_views.cc View 1 2 3 4 5 6 7 7 chunks +25 lines, -25 lines 0 comments Download
M chrome/browser/ui/views/frame/app_non_client_frame_view_aura.cc View 2 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/frame/app_panel_browser_frame_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/app_panel_browser_frame_view.cc View 4 chunks +28 lines, -27 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 1 2 3 4 5 6 7 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 3 4 5 6 7 4 chunks +10 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/frame/glass_browser_frame_view.cc View 1 6 chunks +19 lines, -17 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.h View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.cc View 14 chunks +53 lines, -51 lines 0 comments Download
M chrome/browser/ui/views/tab_icon_view.h View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_drag_win.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -2 lines 0 comments Download
M ui/base/dragdrop/drag_utils.h View 3 chunks +4 lines, -4 lines 0 comments Download
M ui/base/dragdrop/drag_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/dragdrop/drag_utils_aura.cc View 1 2 3 4 5 6 7 1 chunk +3 lines, -3 lines 0 comments Download
M ui/base/dragdrop/drag_utils_gtk.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/base/dragdrop/drag_utils_win.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_aura.h View 1 2 3 4 5 6 3 chunks +8 lines, -5 lines 0 comments Download
M ui/base/native_theme/native_theme_android.h View 3 chunks +4 lines, -3 lines 0 comments Download
M ui/base/native_theme/native_theme_android.cc View 1 2 3 4 5 6 7 8 chunks +29 lines, -27 lines 0 comments Download
M ui/base/native_theme/native_theme_aura.cc View 13 chunks +19 lines, -12 lines 0 comments Download
M ui/base/native_theme/native_theme_base.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/base/native_theme/native_theme_base.cc View 1 2 3 7 chunks +30 lines, -27 lines 0 comments Download
M ui/oak/oak_window.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/oak/oak_window.cc View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/bubble/bubble_border.h View 2 chunks +5 lines, -3 lines 0 comments Download
M ui/views/bubble/bubble_border.cc View 1 2 3 4 5 6 5 chunks +40 lines, -40 lines 0 comments Download
M ui/views/button_drag_utils.h View 2 chunks +5 lines, -2 lines 0 comments Download
M ui/views/button_drag_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/painter.h View 3 chunks +3 lines, -4 lines 0 comments Download
M ui/views/painter.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M ui/views/view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_aura.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/widget/native_widget_aura.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/widget/native_widget_private.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/views/widget/native_widget_win.h View 7 8 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/widget/native_widget_win.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/widget/widget_delegate.h View 2 chunks +3 lines, -4 lines 0 comments Download
M ui/views/widget/widget_delegate.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/views/window/custom_frame_view.h View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/views/window/custom_frame_view.cc View 5 chunks +33 lines, -28 lines 0 comments Download
M ui/views/window/frame_background.h View 1 4 chunks +27 lines, -27 lines 0 comments Download
M ui/views/window/frame_background.cc View 5 chunks +19 lines, -19 lines 0 comments Download
M ui/views/window/window_resources.h View 1 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
pkotwicz
8 years, 7 months ago (2012-05-26 23:17:36 UTC) #1
msw
http://codereview.chromium.org/10447053/diff/10002/ui/views/bubble/bubble_border.cc File ui/views/bubble/bubble_border.cc (right): http://codereview.chromium.org/10447053/diff/10002/ui/views/bubble/bubble_border.cc#newcode12 ui/views/bubble/bubble_border.cc:12: #include "ui/gfx/image/image_skia.h" Drive by nit: Run tools/sort-headers.py on the ...
8 years, 6 months ago (2012-05-29 07:49:16 UTC) #2
tfarina
On Tue, May 29, 2012 at 4:49 AM, <msw@chromium.org> wrote: > > http://codereview.chromium.org/10447053/diff/10002/ui/views/bubble/bubble_border.cc > File ...
8 years, 6 months ago (2012-05-29 13:55:00 UTC) #3
pkotwicz
Sorted headers
8 years, 6 months ago (2012-05-29 16:28:44 UTC) #4
sky
LGTM http://codereview.chromium.org/10447053/diff/1100/ash/shell/content_client/shell_content_browser_client.cc File ash/shell/content_client/shell_content_browser_client.cc (right): http://codereview.chromium.org/10447053/diff/1100/ash/shell/content_client/shell_content_browser_client.cc#newcode128 ash/shell/content_client/shell_content_browser_client.cc:128: static gfx::ImageSkia empty; This should be a static ...
8 years, 6 months ago (2012-05-29 17:18:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10447053/4008
8 years, 6 months ago (2012-05-31 01:45:32 UTC) #6
commit-bot: I haz the power
8 years, 6 months ago (2012-05-31 04:46:08 UTC) #7
Change committed as 139734

Powered by Google App Engine
This is Rietveld 408576698