Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10386223: Renaming poorly named classes and adding missing unit tests. (Closed)

Created:
8 years, 7 months ago by dominich
Modified:
8 years, 7 months ago
Reviewers:
jam, gavinp, sky
CC:
chromium-reviews, cbentzel+watch_chromium.org, tburkard+watch_chromium.org, dominich+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, mmenke
Visibility:
Public.

Description

Renaming poorly named classes and adding missing unit tests. BUG=128728

Patch Set 1 #

Patch Set 2 : Fix windows build #

Patch Set 3 : Undo rename of Dispatcher #

Unified diffs Side-by-side diffs Delta from patch set Stats (+625 lines, -801 lines) Patch
M chrome/browser/browser_process.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/browser_process_impl.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 3 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/prerender/prerender_contents.h View 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/prerender/prerender_contents.cc View 7 chunks +14 lines, -11 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.h View 4 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/prerender/prerender_manager_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/prerender/prerender_render_view_tracker.h View 5 chunks +23 lines, -17 lines 0 comments Download
A + chrome/browser/prerender/prerender_render_view_tracker.cc View 11 chunks +25 lines, -27 lines 0 comments Download
A chrome/browser/prerender/prerender_render_view_tracker_unittest.cc View 1 chunk +330 lines, -0 lines 0 comments Download
D chrome/browser/prerender/prerender_tracker.h View 1 chunk +0 lines, -141 lines 0 comments Download
D chrome/browser/prerender/prerender_tracker.cc View 1 chunk +0 lines, -220 lines 0 comments Download
D chrome/browser/prerender/prerender_tracker_unittest.cc View 1 chunk +0 lines, -298 lines 0 comments Download
M chrome/browser/prerender/prerender_unittest.cc View 8 chunks +22 lines, -21 lines 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 6 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/renderer_host/safe_browsing_resource_throttle.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
D chrome/renderer/prerender/prerender_dispatcher.h View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
D chrome/renderer/prerender/prerender_dispatcher.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
A chrome/renderer/prerender/prerender_dispatcher_unittest.cc View 1 2 1 chunk +114 lines, -0 lines 0 comments Download
M chrome/test/base/testing_browser_process.h View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/test/base/testing_browser_process.cc View 2 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dominich
sky: This is just a blanket rename of two classes through the code-base. gavinp: Please ...
8 years, 7 months ago (2012-05-18 21:18:10 UTC) #1
sky
Rubber stamp LGTM - make sure you use svn so that history isn't lost.
8 years, 7 months ago (2012-05-18 22:05:31 UTC) #2
jam
please don't commit this. this isn't poorly named, it matches the convention for other classes. ...
8 years, 7 months ago (2012-05-21 17:41:43 UTC) #3
dominich
8 years, 7 months ago (2012-05-21 18:46:47 UTC) #4 
Removed rename of PrerenderDispatcher as per jam@

Powered by Google App Engine
This is Rietveld 408576698