Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Side by Side Diff: chrome/renderer/prerender/prerender_dispatcher.cc

Issue 10386223: Renaming poorly named classes and adding missing unit tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Undo rename of Dispatcher Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/prerender/prerender_dispatcher.h" 5 #include "chrome/renderer/prerender/prerender_dispatcher.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "chrome/common/prerender_messages.h" 8 #include "chrome/common/prerender_messages.h"
9 #include "chrome/renderer/prerender/prerendering_support.h" 9 #include "chrome/renderer/prerender/prerendering_support.h"
10 #include "googleurl/src/gurl.h" 10 #include "googleurl/src/gurl.h"
(...skipping 21 matching lines...) Expand all
32 IPC_MESSAGE_UNHANDLED(handled = false) 32 IPC_MESSAGE_UNHANDLED(handled = false)
33 IPC_END_MESSAGE_MAP() 33 IPC_END_MESSAGE_MAP()
34 34
35 return handled; 35 return handled;
36 } 36 }
37 37
38 void PrerenderDispatcher::OnAddPrerenderURL(const GURL& url) { 38 void PrerenderDispatcher::OnAddPrerenderURL(const GURL& url) {
39 PrerenderMap::iterator it = prerender_urls_.find(url); 39 PrerenderMap::iterator it = prerender_urls_.find(url);
40 if (it != prerender_urls_.end()) { 40 if (it != prerender_urls_.end()) {
41 DCHECK(it->second > 0); 41 DCHECK(it->second > 0);
42 it->second += 1; 42 ++it->second;
43 } else { 43 } else {
44 prerender_urls_[url] = 1; 44 prerender_urls_[url] = 1;
45 } 45 }
46 } 46 }
47 47
48 void PrerenderDispatcher::OnRemovePrerenderURL(const GURL& url) { 48 void PrerenderDispatcher::OnRemovePrerenderURL(const GURL& url) {
49 PrerenderMap::iterator it = prerender_urls_.find(url); 49 PrerenderMap::iterator it = prerender_urls_.find(url);
50 // This is possible with a spurious remove. 50 // This is possible with a spurious remove.
51 // TODO(cbentzel): We'd also want to send the map of active prerenders when 51 // TODO(cbentzel): We'd also want to send the map of active prerenders when
52 // creating a new render process, so the Add/Remove go relative to that. 52 // creating a new render process, so the Add/Remove go relative to that.
53 // This may not be that big of a deal in practice, since the newly created tab 53 // This may not be that big of a deal in practice, since the newly created tab
54 // is unlikely to go to the prerendered page. 54 // is unlikely to go to the prerendered page.
55 if (it == prerender_urls_.end()) 55 if (it == prerender_urls_.end())
56 return; 56 return;
57 DCHECK(it->second > 0); 57 DCHECK(it->second > 0);
58 it->second -= 1; 58 --it->second;
59 if (it->second == 0) 59 if (it->second == 0)
60 prerender_urls_.erase(it); 60 prerender_urls_.erase(it);
61 } 61 }
62 62
63 } // namespace prerender 63 } // namespace prerender
OLDNEW
« no previous file with comments | « chrome/renderer/prerender/prerender_dispatcher.h ('k') | chrome/renderer/prerender/prerender_dispatcher_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698