Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Side by Side Diff: chrome/browser/browser_process_impl.h

Issue 10386223: Renaming poorly named classes and adding missing unit tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Undo rename of Dispatcher Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/browser_process.h ('k') | chrome/browser/browser_process_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // When each service is created, we set a flag indicating this. At this point, 5 // When each service is created, we set a flag indicating this. At this point,
6 // the service initialization could fail or succeed. This allows us to remember 6 // the service initialization could fail or succeed. This allows us to remember
7 // if we tried to create a service, and not try creating it over and over if 7 // if we tried to create a service, and not try creating it over and over if
8 // the creation failed. 8 // the creation failed.
9 9
10 #ifndef CHROME_BROWSER_BROWSER_PROCESS_IMPL_H_ 10 #ifndef CHROME_BROWSER_BROWSER_PROCESS_IMPL_H_
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 virtual SafeBrowsingService* safe_browsing_service() OVERRIDE; 104 virtual SafeBrowsingService* safe_browsing_service() OVERRIDE;
105 virtual safe_browsing::ClientSideDetectionService* 105 virtual safe_browsing::ClientSideDetectionService*
106 safe_browsing_detection_service() OVERRIDE; 106 safe_browsing_detection_service() OVERRIDE;
107 virtual bool plugin_finder_disabled() const OVERRIDE; 107 virtual bool plugin_finder_disabled() const OVERRIDE;
108 108
109 #if (defined(OS_WIN) || defined(OS_LINUX)) && !defined(OS_CHROMEOS) 109 #if (defined(OS_WIN) || defined(OS_LINUX)) && !defined(OS_CHROMEOS)
110 virtual void StartAutoupdateTimer() OVERRIDE; 110 virtual void StartAutoupdateTimer() OVERRIDE;
111 #endif 111 #endif
112 112
113 virtual ChromeNetLog* net_log() OVERRIDE; 113 virtual ChromeNetLog* net_log() OVERRIDE;
114 virtual prerender::PrerenderTracker* prerender_tracker() OVERRIDE; 114 virtual prerender::PrerenderRenderViewTracker*
115 prerender_render_view_tracker() OVERRIDE;
115 virtual ComponentUpdateService* component_updater() OVERRIDE; 116 virtual ComponentUpdateService* component_updater() OVERRIDE;
116 virtual CRLSetFetcher* crl_set_fetcher() OVERRIDE; 117 virtual CRLSetFetcher* crl_set_fetcher() OVERRIDE;
117 118
118 // content::NotificationObserver implementation. 119 // content::NotificationObserver implementation.
119 virtual void Observe(int type, 120 virtual void Observe(int type,
120 const content::NotificationSource& source, 121 const content::NotificationSource& source,
121 const content::NotificationDetails& details) OVERRIDE; 122 const content::NotificationDetails& details) OVERRIDE;
122 123
123 private: 124 private:
124 void CreateMetricsService(); 125 void CreateMetricsService();
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
226 227
227 // Ensures that the observers of plugin/print disable/enable state 228 // Ensures that the observers of plugin/print disable/enable state
228 // notifications are properly added and removed. 229 // notifications are properly added and removed.
229 PrefChangeRegistrar pref_change_registrar_; 230 PrefChangeRegistrar pref_change_registrar_;
230 231
231 // Lives here so can safely log events on shutdown. 232 // Lives here so can safely log events on shutdown.
232 scoped_ptr<ChromeNetLog> net_log_; 233 scoped_ptr<ChromeNetLog> net_log_;
233 234
234 // Ordered before resource_dispatcher_host_delegate_ due to destruction 235 // Ordered before resource_dispatcher_host_delegate_ due to destruction
235 // ordering. 236 // ordering.
236 scoped_ptr<prerender::PrerenderTracker> prerender_tracker_; 237 scoped_ptr<prerender::PrerenderRenderViewTracker>
238 prerender_render_view_tracker_;
237 239
238 scoped_ptr<ChromeResourceDispatcherHostDelegate> 240 scoped_ptr<ChromeResourceDispatcherHostDelegate>
239 resource_dispatcher_host_delegate_; 241 resource_dispatcher_host_delegate_;
240 242
241 // Monitors the state of the 'DisablePluginFinder' policy. 243 // Monitors the state of the 'DisablePluginFinder' policy.
242 scoped_ptr<BooleanPrefMember> plugin_finder_disabled_pref_; 244 scoped_ptr<BooleanPrefMember> plugin_finder_disabled_pref_;
243 245
244 #if (defined(OS_WIN) || defined(OS_LINUX)) && !defined(OS_CHROMEOS) 246 #if (defined(OS_WIN) || defined(OS_LINUX)) && !defined(OS_CHROMEOS)
245 base::RepeatingTimer<BrowserProcessImpl> autoupdate_timer_; 247 base::RepeatingTimer<BrowserProcessImpl> autoupdate_timer_;
246 248
(...skipping 13 matching lines...) Expand all
260 #endif 262 #endif
261 263
262 // TODO(eroman): Remove this when done debugging 113031. This tracks 264 // TODO(eroman): Remove this when done debugging 113031. This tracks
263 // the callstack which released the final module reference count. 265 // the callstack which released the final module reference count.
264 base::debug::StackTrace release_last_reference_callstack_; 266 base::debug::StackTrace release_last_reference_callstack_;
265 267
266 DISALLOW_COPY_AND_ASSIGN(BrowserProcessImpl); 268 DISALLOW_COPY_AND_ASSIGN(BrowserProcessImpl);
267 }; 269 };
268 270
269 #endif // CHROME_BROWSER_BROWSER_PROCESS_IMPL_H_ 271 #endif // CHROME_BROWSER_BROWSER_PROCESS_IMPL_H_
OLDNEW
« no previous file with comments | « chrome/browser/browser_process.h ('k') | chrome/browser/browser_process_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698