Renaming poorly named classes and adding missing unit tests.

chrome/browser/prerender/prerender_render_view_tracker.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CHROME_BROWSER_PRERENDER_PRERENDER_TRACKER_H_
-#define CHROME_BROWSER_PRERENDER_PRERENDER_TRACKER_H_
+#ifndef CHROME_BROWSER_PRERENDER_PRERENDER_RENDER_VIEW_TRACKER_H_
+#define CHROME_BROWSER_PRERENDER_PRERENDER_RENDER_VIEW_TRACKER_H_
 #pragma once
 
 #include <map>
 #include <set>
 #include <vector>
 
 #include "base/gtest_prod_util.h"
 #include "base/synchronization/lock.h"
 #include "base/threading/non_thread_safe.h"
 #include "chrome/browser/prerender/prerender_final_status.h"
 #include "googleurl/src/gurl.h"
 
 namespace prerender {
 
 class PrerenderManager;
 struct RenderViewInfo;
 
-// PrerenderTracker is responsible for keeping track of all prerendering
-// RenderViews and their statuses.  Its list is guaranteed to be up to date
-// and can be modified on any thread.
-class PrerenderTracker {
+// PrerenderRenderViewTracker is responsible for keeping track of all
+// prerendering RenderViews and their statuses. Its list is guaranteed to be up
+// to date and can be modified on any thread.
+class PrerenderRenderViewTracker {
  public:
-  PrerenderTracker();
-  ~PrerenderTracker();
+  PrerenderRenderViewTracker();
+  ~PrerenderRenderViewTracker();
 
   // Attempts to set the status of the specified RenderViewHost to
   // FINAL_STATUS_USED.  Returns true on success.  Returns false if it has
   // already been cancelled for any reason or is no longer prerendering.
   // Can only be called only on the IO thread.  This method will not call
   // PrerenderContents::set_final_status() on the corresponding
   // PrerenderContents.
   //
   // If it returns true, all subsequent calls to TryCancel and TryUse for the
   // RenderView will return false.
@@ skipping 21 matching lines @@
   bool GetFinalStatus(int child_id, int route_id,
                       FinalStatus* final_status) const;
 
   // Returns whether or not a RenderView is prerendering.  Can only be called on
   // the IO thread.  Does not acquire a lock, so may claim a RenderView that has
   // been displayed or destroyed is still prerendering.
   bool IsPrerenderingOnIOThread(int child_id, int route_id) const;
 
  private:
   friend class PrerenderContents;
-  FRIEND_TEST_ALL_PREFIXES(PrerenderTrackerTest, PrerenderTrackerNull);
-  FRIEND_TEST_ALL_PREFIXES(PrerenderTrackerTest, PrerenderTrackerUsed);
-  FRIEND_TEST_ALL_PREFIXES(PrerenderTrackerTest, PrerenderTrackerCancelled);
-  FRIEND_TEST_ALL_PREFIXES(PrerenderTrackerTest, PrerenderTrackerCancelledOnIO);
-  FRIEND_TEST_ALL_PREFIXES(PrerenderTrackerTest, PrerenderTrackerCancelledFast);
-  FRIEND_TEST_ALL_PREFIXES(PrerenderTrackerTest, PrerenderTrackerMultiple);
+  FRIEND_TEST_ALL_PREFIXES(PrerenderRenderViewTrackerTest,
+                           PrerenderRenderViewTrackerNull);
+  FRIEND_TEST_ALL_PREFIXES(PrerenderRenderViewTrackerTest,
+                           PrerenderRenderViewTrackerUsed);
+  FRIEND_TEST_ALL_PREFIXES(PrerenderRenderViewTrackerTest,
+                           PrerenderRenderViewTrackerCancelled);
+  FRIEND_TEST_ALL_PREFIXES(PrerenderRenderViewTrackerTest,
+                           PrerenderRenderViewTrackerCancelledOnIO);
+  FRIEND_TEST_ALL_PREFIXES(PrerenderRenderViewTrackerTest,
+                           PrerenderRenderViewTrackerCancelledFast);
+  FRIEND_TEST_ALL_PREFIXES(PrerenderRenderViewTrackerTest,
+                           PrerenderRenderViewTrackerMultiple);
 
   typedef std::pair<int, int> ChildRouteIdPair;
   // Map of child/route id pairs to final statuses.
   typedef std::map<ChildRouteIdPair, RenderViewInfo> FinalStatusMap;
   // Set of child/route id pairs that may be prerendering.
   typedef std::set<ChildRouteIdPair> PossiblyPrerenderingChildRouteIdPairs;
 
   // Must be called when a RenderView starts prerendering, before the first
   // navigation starts to avoid any races.
   void OnPrerenderingStarted(int child_id, int route_id,
@@ skipping 24 matching lines @@
   // the IO Thread.
   void AddPrerenderOnIOThread(const ChildRouteIdPair& child_route_id_pair);
   void RemovePrerenderOnIOThread(const ChildRouteIdPair& child_route_id_pair);
 
   // Tasks posted to the IO Thread to call the above functions.
   static void AddPrerenderOnIOThreadTask(
       const ChildRouteIdPair& child_route_id_pair);
   static void RemovePrerenderOnIOThreadTask(
       const ChildRouteIdPair& child_route_id_pair);
 
-  static PrerenderTracker* GetDefault();
+  static PrerenderRenderViewTracker* GetDefault();
 
   // |final_status_map_lock_| protects access to |final_status_map_|.
   mutable base::Lock final_status_map_lock_;
   // Map containing child/route id pairs and their final statuses.  Must only be
   // accessed while the lock is held.  Values are always accurate and up to
   // date.
   FinalStatusMap final_status_map_;
 
   // Superset of child/route id pairs that are prerendering.  Can only access on
   // the IO thread.  May contain entries that have since been displayed.  Only
   // used to prevent locking when not needed.
   PossiblyPrerenderingChildRouteIdPairs possibly_prerendering_io_thread_set_;
 
-  DISALLOW_COPY_AND_ASSIGN(PrerenderTracker);
+  DISALLOW_COPY_AND_ASSIGN(PrerenderRenderViewTracker);
 };
 
 }  // namespace prerender
 
-#endif  // CHROME_BROWSER_PRERENDER_PRERENDER_TRACKER_H_
+#endif  // CHROME_BROWSER_PRERENDER_PRERENDER_RENDER_VIEW_TRACKER_H_