Only block alert() requests from blocked popups; not all popups....

Only block alert() requests from blocked popups; not all popups.

Add two unit tests to make sure we do the right thing; required
adding a bunch of stuff to the automation layer.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=5198

[Mark Larson, 2008-11-11 00:48:37]

The change to WebContents looks good to me. 

Please get someone else to review these changes. I don't understand the
WebContents delegate, and really don't the know the automation code.

[Elliot Glaysher, 2008-11-11 00:52:32]

Adding Finnur to the list of reviewers; could you please review the automation
changes I've made?

[Finnur, 2008-11-11 07:28:33]

LGTM, with minor nits.

[Finnur, 2008-11-11 07:30:03]

Ooops, I did a reply and not a publish. This fixes that. 
Again: LGTM, with only minor nits.

http://codereview.chromium.org/10282/diff/12/22
File chrome/browser/web_contents.cc (right):

http://codereview.chromium.org/10282/diff/12/22#newcode1080
Line 1080: suppress_this_message |= (delegate()->GetConstrainingContents(this)
!= NULL);
Exceeds 80 chars.

http://codereview.chromium.org/10282/diff/12/16
File chrome/test/automation/automation_messages_internal.h (right):

http://codereview.chromium.org/10282/diff/12/16#newcode804
Line 804: // Querries whether an app modal dialog is currently being shown.
(i.e. a
Queries (one r)

http://codereview.chromium.org/10282/diff/12/16#newcode808
Line 808: bool /* showning dialog */)
Showing (one n).

http://codereview.chromium.org/10282/diff/12/17
File chrome/test/automation/automation_proxy.cc (right):

http://codereview.chromium.org/10282/diff/12/17#newcode338
Line 338: bool dialog_shown;
For good measure I would initialize this to false.

http://codereview.chromium.org/10282/diff/12/13
File chrome/test/data/constrained_files/block_alert.html (right):

http://codereview.chromium.org/10282/diff/12/13#newcode5
Line 5: if (location.search.indexOf("popup") != -1) {
The indentation here is weird. Same below...

http://codereview.chromium.org/10282/diff/12/13#newcode6
Line 6: document.write("This should still be inside the tab, but it is now in "
+
Not conforming to 80 chars? :)