Only block alert() requests from blocked popups; not all popups....

chrome/test/automation/automation_proxy.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <sstream>
 
 #include "chrome/test/automation/automation_proxy.h"
 
 #include "base/logging.h"
 #include "base/ref_counted.h"
@@ skipping 284 matching lines @@
       DLOG(ERROR) << "GetBrowserWindowCount returned false";
     } else if (count == new_count) {
       return true;
     }
     Sleep(automation::kSleepTime);
   }
   // Window count never reached the value we sought.
   return false;
 }
 
+bool AutomationProxy::GetShowingAppModalDialog(bool* showing_app_modal_dialog) {
+  if (!showing_app_modal_dialog) {
+    NOTREACHED();
+    return false;
+  }
+
+  IPC::Message* response = NULL;
+  bool is_timeout = true;
+  bool succeeded = SendAndWaitForResponseWithTimeout(
+      new AutomationMsg_ShowingAppModalDialogRequest(0), &response,
+      AutomationMsg_ShowingAppModalDialogResponse::ID,
+      kMaxCommandExecutionTime, &is_timeout);
+  if (!succeeded)
+    return false;
+
+  if (is_timeout) {
+    DLOG(ERROR) << "ShowingAppModalDialog did not complete in a timely fashion";
+    return false;
+  }
+
+  void* iter = NULL;
+  if (!response->ReadBool(&iter, showing_app_modal_dialog)) {
+    succeeded = false;
+  }
+
+  delete response;
+  return succeeded;
+}
+
+bool AutomationProxy::WaitForAppModalDialog(int wait_timeout) {
+  const TimeTicks start = TimeTicks::Now();
+  const TimeDelta timeout = TimeDelta::FromMilliseconds(wait_timeout);
+  while (TimeTicks::Now() - start < timeout) {
+    bool dialog_shown;

[Finnur, 2008/11/11 07:30:03]

For good measure I would initialize this to false.

+    bool succeeded = GetShowingAppModalDialog(&dialog_shown);
+    if (!succeeded) {
+      // Try again next round, but log it.
+      DLOG(ERROR) << "GetBrowserWindowCount returned false";
+    } else if (dialog_shown) {
+      return true;
+    }
+    Sleep(automation::kSleepTime);
+  }
+  // Dialog never shown.
+  return false;
+}
+
 bool AutomationProxy::SetFilteredInet(bool enabled) {
   return Send(new AutomationMsg_SetFilteredInet(0, enabled));
 }
 
 void AutomationProxy::Disconnect() {
   channel_.reset();
 }
 
 void AutomationProxy::OnMessageReceived(const IPC::Message& msg) {
   // This won't get called unless AutomationProxy is run from
@@ skipping 237 matching lines @@
         (handle >= 0)) {
       succeeded = true;
       tab_proxy = new TabProxy(this, tracker_.get(), handle);
     }
   } else {
     succeeded = false;
   }
   delete response;
   return tab_proxy;
 }