chrome/test/data/constrained_files/block_alert.html - Issue 10282: Only block alert() requests from blocked popups; not all popups....

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/constrained_files/block_alert.html

Issue 10282: Only block alert() requests from blocked popups; not all popups.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 12 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <title>Block alert from blocked popup?</title>

	4 <script>

	5 if (location.search.indexOf("popup") != -1) {
	Finnur 2008/11/11 07:30:03 The indentation here is weird. Same below... The indentation here is weird. Same below...
	6 document.write("This should still be inside the tab, but it is now in " +
	Finnur 2008/11/11 07:30:03 Not conforming to 80 chars? :) Not conforming to 80 chars? :)
	7 "a new window!");

	8 alert("The popup has been \"popped out\" of the tab");

	9 } else {

	10 window.open("?popup");

	11 }

	12 </script>

	13 </head>

	14 <body>

	15 <h1>Block alert from blocked popup?</h1>

	16 </body>

	17 </html>

OLD	NEW