Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4319)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/web_contents.cc

Issue 10282: Only block alert() requests from blocked popups; not all popups.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/views/constrained_window_impl_interactive_uitest.cc ('k') | chrome/test/automation/automation_messages_internal.h » ('j') | chrome/test/automation/automation_messages_internal.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/web_contents.cc
===================================================================
--- chrome/browser/web_contents.cc (revision 5108)
+++ chrome/browser/web_contents.cc (working copy)
@@ -1077,7 +1077,7 @@
// constrained window jail).
bool suppress_this_message = suppress_javascript_messages_;
if (delegate())
- suppress_this_message |= delegate()->IsPopup(this);
+ suppress_this_message |= (delegate()->GetConstrainingContents(this) != NULL);
Finnur 2008/11/11 07:30:03 Exceeds 80 chars.
*did_suppress_message = suppress_this_message;
« no previous file with comments | « chrome/browser/views/constrained_window_impl_interactive_uitest.cc ('k') | chrome/test/automation/automation_messages_internal.h » ('j') | chrome/test/automation/automation_messages_internal.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698