Chromium Code Reviews Chromium Code Reviews
Issue
10162017:
Re-reland Propagate OnNativeWidgetMove to delegate/observers, etc. (Closed)
DescriptionRe-reland Propagate OnNativeWidgetMove to delegate/observers, etc.
Continuation of reverted CL http://codereview.chromium.org/10025039
Relanding this patch exposed a new issues on cros:
1) KioskModeTest.EnableKioskModeTest fails (did unrelated cleanup).
2) Some bubbles crash OnWidgetMove (make |move_with_anchor_| opt-in).
3) Some bubbles crash OnWidgetClosing (cache |anchor_widget_|).
2nd patch description:
Continuation of reverted CL http://codereview.chromium.org/10021029
The original CL was reverted due to a naming conflict between:
WidgetDelegate::OnWidgetMove and Widget::Observer::OnWidgetMove.
I renamed the new Observer method to OnWidgetMoved.
Original description:
Propagate OnNativeWidgetMove to delegate/observers, etc.
NativeWidget[Aura|Win] calls new Widget::OnNativeWidgetMove.
Widgets alert delegates and new Widget::Observer::OnWidgetMove.
TabDragController2: consume new observer method, simplify.
Nix BrowserWindowMoveObserver; use Widget::Observer instead.
Replace move_loop_browser_view_ with move_loop_widget.
Replace GetAttachedBrowserView with GetAttachedBrowserWidget.
BubbleDelegateView: consume new observer method.
Make bubbles move with their anchor_view's Widgets.
SchedulePaint on BubbleFrameView when mirroring its arrow.
BUG=105151, 116336, 124310, 124324, 124352, chromium-os:29747
TEST=Bubbles can move with the browser window (inspecting extension popups, etc.); no Ash / --enable-tab-browser-dragging regressions.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133495
Patch Set 1 : Original CL 10021029 #Patch Set 2 : Cache anchor_widget_, add move_with_anchor_ flag, etc. #Patch Set 3 : Sync and merge. #Messages
Total messages: 4 (0 generated)
|
