Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 10025039: Reland Propagate OnNativeWidgetMove to delegate/observers, etc. (Closed)

Created:
8 years, 8 months ago by msw
Modified:
8 years, 8 months ago
CC:
chromium-reviews, msw+watch_chromium.org, alicet1, ben+watch_chromium.org, dcheng, tfarina, sky, Yusuke Sato
Visibility:
Public.

Description

Reland Propagate OnNativeWidgetMove to delegate/observers, etc. Continuation of reverted CL http://codereview.chromium.org/10021029 The original CL was reverted due to a naming conflict between: WidgetDelegate::OnWidgetMove and Widget::Observer::OnWidgetMove. I renamed the new Observer method to OnWidgetMoved. Original description: Propagate OnNativeWidgetMove to delegate/observers, etc. NativeWidget[Aura|Win] calls new Widget::OnNativeWidgetMove. Widgets alert delegates and new Widget::Observer::OnWidgetMove. TabDragController2: consume new observer method, simplify. Nix BrowserWindowMoveObserver; use Widget::Observer instead. Replace move_loop_browser_view_ with move_loop_widget. Replace GetAttachedBrowserView with GetAttachedBrowserWidget. BubbleDelegateView: consume new observer method. Make bubbles move with their anchor_view's Widgets. SchedulePaint on BubbleFrameView when mirroring its arrow. BUG=105151, 116336 TEST=Bubbles can move with the browser window (inspecting extension popups, etc.); no Ash / --enable-tab-browser-dragging regressions. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133057

Patch Set 1 : Original CL 10021029 #

Patch Set 2 : Rename views::Widget::Observer::OnWidgetMoved to avoid conflicts with WidgetDelegate::OnWidgetMove. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -87 lines) Patch
M chrome/browser/ui/views/frame/browser_view.h View 3 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 3 chunks +0 lines, -5 lines 0 comments Download
D chrome/browser/ui/views/frame/browser_window_move_observer.h View 1 chunk +0 lines, -18 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller2.h View 1 5 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller2.cc View 1 10 chunks +24 lines, -30 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/bubble/bubble_delegate.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/bubble/bubble_delegate.cc View 1 2 chunks +26 lines, -10 lines 0 comments Download
M ui/views/bubble/bubble_frame_view.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/views/widget/native_widget_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_delegate.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/widget/native_widget_win.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M ui/views/widget/widget.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M ui/views/widget/widget.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
msw
Hey Ben, please review this minor CL update; thanks!
8 years, 8 months ago (2012-04-19 18:53:25 UTC) #1
Ben Goodger (Google)
lgtm
8 years, 8 months ago (2012-04-19 19:03:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/10025039/6001
8 years, 8 months ago (2012-04-19 19:07:23 UTC) #3
commit-bot: I haz the power
8 years, 8 months ago (2012-04-19 21:17:58 UTC) #4
Change committed as 133057

Powered by Google App Engine
This is Rietveld 408576698