Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2710)

Unified Diff: chrome/browser/ui/views/extensions/extension_popup.cc

Issue 10162017: Re-reland Propagate OnNativeWidgetMove to delegate/observers, etc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sync and merge. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/extension_popup.cc
diff --git a/chrome/browser/ui/views/extensions/extension_popup.cc b/chrome/browser/ui/views/extensions/extension_popup.cc
index 9e213be1e8fdf3dfd10fb34c5c7bbe351c55f57e..6718e31f9ef61e5c09e20171e57efe959779350a 100644
--- a/chrome/browser/ui/views/extensions/extension_popup.cc
+++ b/chrome/browser/ui/views/extensions/extension_popup.cc
@@ -71,6 +71,8 @@ ExtensionPopup::ExtensionPopup(
host->view()->SetContainer(this);
// Use OnNativeFocusChange to check for child window activation on deactivate.
set_close_on_deactivate(false);
+ // Make the bubble move with its anchor (during inspection, etc.).
+ set_move_with_anchor(true);
// Wait to show the popup until the contained host finishes loading.
registrar_.Add(this, content::NOTIFICATION_LOAD_COMPLETED_MAIN_FRAME,
@@ -125,7 +127,6 @@ void ExtensionPopup::Observe(int type,
// Set inspect_with_devtools_ so the popup will be kept open while
// the devtools are open.
inspect_with_devtools_ = true;
- set_close_on_deactivate(false);
}
break;
default:
« no previous file with comments | « chrome/browser/ui/views/extensions/bundle_installed_bubble.cc ('k') | chrome/browser/ui/views/frame/browser_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698