Propagate OnNativeWidgetMove to delegate/observers, etc.

Propagate OnNativeWidgetMove to delegate/observers, etc.
NativeWidget[Aura|Win] calls new Widget::OnNativeWidgetMove.
Widgets alert delegates and new Widget::Observer::OnWidgetMove.

TabDragController2: consume new observer method, simplify.
Nix BrowserWindowMoveObserver; use Widget::Observer instead.
Replace move_loop_browser_view_ with move_loop_widget.
Replace GetAttachedBrowserView with GetAttachedBrowserWidget.

BubbleDelegateView: consume new observer method.
Make bubbles move with their anchor_view's Widgets.
SchedulePaint on BubbleFrameView when mirroring its arrow.

BUG=105151, 116336
TEST=Bubbles can move with the browser window (inspecting extension popups, etc.); no Ash / --enable-tab-browser-dragging regressions.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132956

[msw, 2012-04-18 01:36:39]

Ben and Scott, please take a look; thanks!

[Ben Goodger (Google), 2012-04-18 15:56:48]

https://chromiumcodereview.appspot.com/10021029/diff/7001/chrome/browser/ui/v...
File chrome/browser/ui/views/tabs/tab_drag_controller2.cc (right):

https://chromiumcodereview.appspot.com/10021029/diff/7001/chrome/browser/ui/v...
chrome/browser/ui/views/tabs/tab_drag_controller2.cc:605:
move_loop_browser_view_->GetWidget()->RemoveObserver(this);
Now that the only usage of |move_loop_browser_view_| is to obtain its widget,
can we just replace it with a Widget*? e.g.

views::Widget* move_loop_widget_;

[msw, 2012-04-18 20:02:48]

I also replaced GetAttachedBrowserView with GetAttachedBrowserWidget to simplify
the code a bit.
I found an existing issue in testing: http://crbug.com/124051
Please take another look; thanks!

https://chromiumcodereview.appspot.com/10021029/diff/7001/chrome/browser/ui/v...
File chrome/browser/ui/views/tabs/tab_drag_controller2.cc (right):

https://chromiumcodereview.appspot.com/10021029/diff/7001/chrome/browser/ui/v...
chrome/browser/ui/views/tabs/tab_drag_controller2.cc:605:
move_loop_browser_view_->GetWidget()->RemoveObserver(this);
On 2012/04/18 15:56:48, Ben Goodger (Google) wrote:
> Now that the only usage of |move_loop_browser_view_| is to obtain its widget,
> can we just replace it with a Widget*? e.g.
> 
> views::Widget* move_loop_widget_;

Done.

[Ben Goodger (Google), 2012-04-18 20:20:52]

lgtm

[commit-bot: I haz the power, 2012-04-18 22:22:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/10021029/1018

[commit-bot: I haz the power, 2012-04-19 02:06:06]

Try job failure for 10021029-1018 (retry) on win_rel for step "net_unittests"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-04-19 03:02:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/10021029/1018

[commit-bot: I haz the power, 2012-04-19 05:39:39]

Change committed as 132956