Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10109001: Replace all LOGs in input_method/, except two user-facing errors, to DVLOG(1). (Closed)

Created:
8 years, 8 months ago by Yusuke Sato
Modified:
8 years, 8 months ago
Reviewers:
Zachary Kuznia
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, derat+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Replace all LOGs in input_method/, except two user-facing errors, to DVLOG(1). Our style guide says "DVLOG(1) is the canonical debug "off by default, selectively enabled" call." http://dev.chromium.org/developers/coding-style BUG=chromium-os:19655 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132773

Patch Set 1 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -212 lines) Patch
M chrome/browser/chromeos/input_method/browser_state_monitor.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/input_method/candidate_window.cc View 9 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/input_method/ibus_controller_impl.cc View 28 chunks +50 lines, -50 lines 0 comments Download
M chrome/browser/chromeos/input_method/ibus_engine_controller.cc View 33 chunks +41 lines, -41 lines 0 comments Download
M chrome/browser/chromeos/input_method/ibus_ui_controller.cc View 12 chunks +23 lines, -23 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine.cc View 7 chunks +20 lines, -20 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl.cc View 12 chunks +18 lines, -18 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/input_method/virtual_keyboard_selector.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/input_method/virtual_keyboard_selector_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/xkeyboard.cc View 13 chunks +23 lines, -23 lines 0 comments Download
M chrome/browser/chromeos/input_method/xkeyboard_unittest.cc View 6 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yusuke Sato
8 years, 8 months ago (2012-04-17 03:38:53 UTC) #1
Zachary Kuznia
LGTM, thanks!
8 years, 8 months ago (2012-04-17 03:42:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/10109001/2001
8 years, 8 months ago (2012-04-18 08:27:51 UTC) #3
commit-bot: I haz the power
8 years, 8 months ago (2012-04-18 10:10:44 UTC) #4 
Change committed as 132773

Powered by Google App Engine
This is Rietveld 408576698