Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1942)

Unified Diff: chrome/browser/chromeos/input_method/input_method_engine.cc

Issue 10109001: Replace all LOGs in input_method/, except two user-facing errors, to DVLOG(1). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/input_method/input_method_engine.cc
diff --git a/chrome/browser/chromeos/input_method/input_method_engine.cc b/chrome/browser/chromeos/input_method/input_method_engine.cc
index cfba7914312ebeba1af714ad6accb5a444a60b0a..65ad46f5c546dbab2232f9ebbf16a2f6590029a5 100644
--- a/chrome/browser/chromeos/input_method/input_method_engine.cc
+++ b/chrome/browser/chromeos/input_method/input_method_engine.cc
@@ -348,7 +348,7 @@ bool InputMethodEngineImpl::SetMenuItems(const std::vector<MenuItem>& items) {
new input_method::IBusEngineController::EngineProperty;
if (!MenuItemToProperty(*item, property)) {
delete property;
- LOG(ERROR) << "Bad menu item";
+ DVLOG(1) << "Bad menu item";
return false;
}
properties.push_back(property);
@@ -416,7 +416,7 @@ bool InputMethodEngineImpl::MenuItemToProperty(
new input_method::IBusEngineController::EngineProperty;
if (!MenuItemToProperty(*child, new_property)) {
delete new_property;
- LOG(ERROR) << "Bad menu item child";
+ DVLOG(1) << "Bad menu item child";
return false;
}
property->children.push_back(new_property);
@@ -434,7 +434,7 @@ bool InputMethodEngineImpl::UpdateMenuItems(
input_method::IBusEngineController::EngineProperty* new_property =
new input_method::IBusEngineController::EngineProperty();
if (!MenuItemToProperty(*item, new_property)) {
- LOG(ERROR) << "Bad menu item";
+ DVLOG(1) << "Bad menu item";
delete new_property;
return false;
}
@@ -513,7 +513,7 @@ void InputMethodEngineImpl::OnCandidateClicked(unsigned int index,
} else if (button & input_method::IBusEngineController::MOUSE_BUTTON_3_MASK) {
pressed_button = MOUSE_BUTTON_RIGHT;
} else {
- LOG(ERROR) << "Unknown button: " << button;
+ DVLOG(1) << "Unknown button: " << button;
pressed_button = MOUSE_BUTTON_LEFT;
}
@@ -538,7 +538,7 @@ class InputMethodEngineStub : public InputMethodEngine {
const char* language,
const std::vector<std::string>& layouts,
std::string* error) {
- VLOG(0) << "Init";
+ DVLOG(1) << "Init";
return true;
}
@@ -547,71 +547,71 @@ class InputMethodEngineStub : public InputMethodEngine {
int selection_end, int cursor,
const std::vector<SegmentInfo>& segments,
std::string* error) {
- VLOG(0) << "SetComposition";
+ DVLOG(1) << "SetComposition";
return true;
}
virtual bool ClearComposition(int context_id, std::string* error) {
- VLOG(0) << "ClearComposition";
+ DVLOG(1) << "ClearComposition";
return true;
}
virtual bool CommitText(int context_id,
const char* text, std::string* error) {
- VLOG(0) << "CommitText";
+ DVLOG(1) << "CommitText";
return true;
}
virtual bool SetCandidateWindowVisible(bool visible, std::string* error) {
- VLOG(0) << "SetCandidateWindowVisible";
+ DVLOG(1) << "SetCandidateWindowVisible";
return true;
}
virtual void SetCandidateWindowCursorVisible(bool visible) {
- VLOG(0) << "SetCandidateWindowCursorVisible";
+ DVLOG(1) << "SetCandidateWindowCursorVisible";
}
virtual void SetCandidateWindowVertical(bool vertical) {
- VLOG(0) << "SetCandidateWindowVertical";
+ DVLOG(1) << "SetCandidateWindowVertical";
}
virtual void SetCandidateWindowPageSize(int size) {
- VLOG(0) << "SetCandidateWindowPageSize";
+ DVLOG(1) << "SetCandidateWindowPageSize";
}
virtual void SetCandidateWindowAuxText(const char* text) {
- VLOG(0) << "SetCandidateWindowAuxText";
+ DVLOG(1) << "SetCandidateWindowAuxText";
}
virtual void SetCandidateWindowAuxTextVisible(bool visible) {
- VLOG(0) << "SetCandidateWindowAuxTextVisible";
+ DVLOG(1) << "SetCandidateWindowAuxTextVisible";
}
virtual bool SetCandidates(int context_id,
const std::vector<Candidate>& candidates,
std::string* error) {
- VLOG(0) << "SetCandidates";
+ DVLOG(1) << "SetCandidates";
return true;
}
virtual bool SetCursorPosition(int context_id, int candidate_id,
std::string* error) {
- VLOG(0) << "SetCursorPosition";
+ DVLOG(1) << "SetCursorPosition";
return true;
}
virtual bool SetMenuItems(const std::vector<MenuItem>& items) {
- VLOG(0) << "SetMenuItems";
+ DVLOG(1) << "SetMenuItems";
return true;
}
virtual bool UpdateMenuItems(const std::vector<MenuItem>& items) {
- VLOG(0) << "UpdateMenuItems";
+ DVLOG(1) << "UpdateMenuItems";
return true;
}
virtual bool IsActive() const {
- VLOG(0) << "IsActive";
+ DVLOG(1) << "IsActive";
return active_;
}
@@ -654,7 +654,7 @@ InputMethodEngine* InputMethodEngine::CreateEngine(
if (!new_engine->Init(observer, engine_name, extension_id, engine_id,
description, language, layouts, error)) {
- LOG(ERROR) << "Init() failed.";
+ DVLOG(1) << "Init() failed.";
delete new_engine;
new_engine = NULL;
}

Powered by Google App Engine
This is Rietveld 408576698