chrome/browser/chromeos/input_method/virtual_keyboard_selector_unittest.cc - Issue 10109001: Replace all LOGs in input_method/, except two user-facing errors, to DVLOG(1).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/input_method/virtual_keyboard_selector_unittest.cc

Issue 10109001: Replace all LOGs in input_method/, except two user-facing errors, to DVLOG(1). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/input_method/virtual_keyboard_selector.cc ('k') | chrome/browser/chromeos/input_method/xkeyboard.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/input_method/virtual_keyboard_selector_unittest.cc

diff --git a/chrome/browser/chromeos/input_method/virtual_keyboard_selector_unittest.cc b/chrome/browser/chromeos/input_method/virtual_keyboard_selector_unittest.cc

index 3734a7e57327b4f7cce26f3b8e438faa66d544e8..f3c9e5aca516f2199d3f97de20c99defcc2935f2 100644

--- a/chrome/browser/chromeos/input_method/virtual_keyboard_selector_unittest.cc

+++ b/chrome/browser/chromeos/input_method/virtual_keyboard_selector_unittest.cc

@@ -27,7 +27,7 @@ template <size_t L> bool CheckUrls(LayoutToKeyboard::const_iterator start,

std::set<GURL> expected_url_set;

for (size_t i = 0; i < L; ++i) {

if (!expected_url_set.insert(GURL(urls[i])).second) {

- LOG(ERROR) << "Duplicated URL: " << urls[i];

+ DVLOG(1) << "Duplicated URL: " << urls[i];

return false;

}

@@ -35,7 +35,7 @@ template <size_t L> bool CheckUrls(LayoutToKeyboard::const_iterator start,

std::set<GURL> actual_url_set;

for (LayoutToKeyboard::const_iterator iter = start; iter != end; ++iter) {

if (!actual_url_set.insert(iter->second->url()).second) {

- LOG(ERROR) << "Duplicated URL: " << iter->second->url().spec();

+ DVLOG(1) << "Duplicated URL: " << iter->second->url().spec();

return false;

}