Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: chrome/browser/chromeos/input_method/input_method_util.cc

Issue 10109001: Replace all LOGs in input_method/, except two user-facing errors, to DVLOG(1). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/input_method/input_method_util.cc
diff --git a/chrome/browser/chromeos/input_method/input_method_util.cc b/chrome/browser/chromeos/input_method/input_method_util.cc
index dc182920ca2cc6a6c0fc7c7627a844d4ea63bf83..a3721b1ecbbd1170b684f1dac19d82154bfd44ab 100644
--- a/chrome/browser/chromeos/input_method/input_method_util.cc
+++ b/chrome/browser/chromeos/input_method/input_method_util.cc
@@ -532,7 +532,7 @@ bool InputMethodUtil::GetInputMethodIdsFromLanguageCodeInternal(
}
}
if ((type == kAllInputMethods) && !result) {
- LOG(ERROR) << "Unknown language code: " << normalized_language_code;
+ DVLOG(1) << "Unknown language code: " << normalized_language_code;
}
return result;
}
@@ -596,7 +596,7 @@ void InputMethodUtil::GetLanguageCodesFromInputMethodIds(
const InputMethodDescriptor* input_method =
GetInputMethodDescriptorFromId(input_method_id);
if (!input_method) {
- LOG(ERROR) << "Unknown input method ID: " << input_method_ids[i];
+ DVLOG(1) << "Unknown input method ID: " << input_method_ids[i];
continue;
}
const std::string language_code = input_method->language_code();
@@ -615,7 +615,7 @@ std::string InputMethodUtil::GetHardwareInputMethodId() const {
if (!(g_browser_process && g_browser_process->local_state())) {
// This shouldn't happen but just in case.
- VLOG(1) << "Local state is not yet ready";
+ DVLOG(1) << "Local state is not yet ready";
return InputMethodDescriptor::GetFallbackInputMethodDescriptor().id();
}
@@ -624,7 +624,7 @@ std::string InputMethodUtil::GetHardwareInputMethodId() const {
// This could happen in unittests. We register the preference in
// BrowserMain::InitializeLocalState and that method is not called during
// unittests.
- LOG(ERROR) << prefs::kHardwareKeyboardLayout << " is not registered";
+ DVLOG(1) << prefs::kHardwareKeyboardLayout << " is not registered";
return InputMethodDescriptor::GetFallbackInputMethodDescriptor().id();
}
@@ -641,7 +641,7 @@ std::string InputMethodUtil::GetHardwareInputMethodId() const {
void InputMethodUtil::ReloadInternalMaps() {
if (supported_input_methods_->size() <= 1) {
- LOG(ERROR) << "GetSupportedInputMethods returned a fallback ID";
+ DVLOG(1) << "GetSupportedInputMethods returned a fallback ID";
// TODO(yusukes): Handle this error in nicer way.
}

Powered by Google App Engine
This is Rietveld 408576698