Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1265)

Unified Diff: chrome/browser/safe_browsing/download_protection_service_unittest.cc

Issue 10068036: RefCounted types should not have public destructors, chrome/browser/ part 5 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Win fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/download_protection_service_unittest.cc
diff --git a/chrome/browser/safe_browsing/download_protection_service_unittest.cc b/chrome/browser/safe_browsing/download_protection_service_unittest.cc
index 75708bb07496f3f8e1d1c62adb3c5524672328ee..c67ae599736c20f4dd6e643d0a7eda29e083160c 100644
--- a/chrome/browser/safe_browsing/download_protection_service_unittest.cc
+++ b/chrome/browser/safe_browsing/download_protection_service_unittest.cc
@@ -46,13 +46,15 @@ namespace {
class MockSafeBrowsingService : public SafeBrowsingService {
public:
MockSafeBrowsingService() {}
- virtual ~MockSafeBrowsingService() {}
MOCK_METHOD1(MatchDownloadWhitelistUrl, bool(const GURL&));
MOCK_METHOD1(MatchDownloadWhitelistString, bool(const std::string&));
MOCK_METHOD2(CheckDownloadUrl, bool(const std::vector<GURL>& url_chain,
Client* client));
+ protected:
+ virtual ~MockSafeBrowsingService() {}
+
private:
DISALLOW_COPY_AND_ASSIGN(MockSafeBrowsingService);
};
@@ -60,10 +62,12 @@ class MockSafeBrowsingService : public SafeBrowsingService {
class MockSignatureUtil : public SignatureUtil {
public:
MockSignatureUtil() {}
- virtual ~MockSignatureUtil() {}
MOCK_METHOD2(CheckSignature,
void(const FilePath&, ClientDownloadRequest_SignatureInfo*));
+ protected:
+ virtual ~MockSignatureUtil() {}
+
private:
DISALLOW_COPY_AND_ASSIGN(MockSignatureUtil);
};

Powered by Google App Engine
This is Rietveld 408576698