chrome/browser/safe_browsing/malware_details_cache.h - Issue 10068036: RefCounted types should not have public destructors, chrome/browser/ part 5

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/malware_details_cache.h

Issue 10068036: RefCounted types should not have public destructors, chrome/browser/ part 5 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Win fix Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/download_protection_service_unittest.cc ('k') | chrome/browser/safe_browsing/malware_details_cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/malware_details_cache.h

diff --git a/chrome/browser/safe_browsing/malware_details_cache.h b/chrome/browser/safe_browsing/malware_details_cache.h

index 383e8b64e24d459e9b6074ac3c83dfa033202378..d52188b7138254b4b65c819eaebb21475a1f3223 100644

--- a/chrome/browser/safe_browsing/malware_details_cache.h

+++ b/chrome/browser/safe_browsing/malware_details_cache.h

@@ -38,7 +38,6 @@ class MalwareDetailsCacheCollector

public:

MalwareDetailsCacheCollector();

- virtual ~MalwareDetailsCacheCollector();

// We use |request_context_getter|, we modify |resources| and

// |result|, and we call |callback|, so they must all remain alive

@@ -58,6 +57,10 @@ class MalwareDetailsCacheCollector

virtual void OnURLFetchComplete(const content::URLFetcher* source) OVERRIDE;

private:

+ friend class base::RefCountedThreadSafe<MalwareDetailsCacheCollector>;

+ virtual ~MalwareDetailsCacheCollector();

// Points to the url for which we are fetching the HTTP cache entry or

// redirect chain.

safe_browsing::ResourceMap::iterator resources_it_;