chrome/browser/safe_browsing/client_side_detection_host_unittest.cc - Issue 10068036: RefCounted types should not have public destructors, chrome/browser/ part 5

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/client_side_detection_host_unittest.cc

Issue 10068036: RefCounted types should not have public destructors, chrome/browser/ part 5 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Win fix Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/profiles/refcounted_profile_keyed_service.h ('k') | chrome/browser/safe_browsing/download_protection_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/client_side_detection_host_unittest.cc

diff --git a/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc b/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc

index 1d68a4dcaf7305d8bb4fd4a3e62c29d4122dd2d6..b39b63b5191668a46ab85d0ee8872e57e017d4e6 100644

--- a/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc

+++ b/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc

@@ -101,7 +101,6 @@ class MockClientSideDetectionService : public ClientSideDetectionService {

class MockSafeBrowsingService : public SafeBrowsingService {

public:

MockSafeBrowsingService() {}

- virtual ~MockSafeBrowsingService() {}

MOCK_METHOD1(DoDisplayBlockingPage, void(const UnsafeResource& resource));

MOCK_METHOD1(MatchCsdWhitelistUrl, bool(const GURL&));

@@ -117,6 +116,9 @@ class MockSafeBrowsingService : public SafeBrowsingService {

callback.Run(false);

}

+ protected:

+ virtual ~MockSafeBrowsingService() {}

private:

DISALLOW_COPY_AND_ASSIGN(MockSafeBrowsingService);

};