Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: chrome/browser/safe_browsing/download_protection_service_unittest.cc

Issue 10068036: RefCounted types should not have public destructors, chrome/browser/ part 5 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Win fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/safe_browsing/download_protection_service.h" 5 #include "chrome/browser/safe_browsing/download_protection_service.h"
6 6
7 #include <map> 7 #include <map>
8 #include <string> 8 #include <string>
9 9
10 #include "base/base_paths.h" 10 #include "base/base_paths.h"
(...skipping 28 matching lines...) Expand all
39 using ::testing::SaveArg; 39 using ::testing::SaveArg;
40 using ::testing::StrictMock; 40 using ::testing::StrictMock;
41 using ::testing::_; 41 using ::testing::_;
42 using content::BrowserThread; 42 using content::BrowserThread;
43 43
44 namespace safe_browsing { 44 namespace safe_browsing {
45 namespace { 45 namespace {
46 class MockSafeBrowsingService : public SafeBrowsingService { 46 class MockSafeBrowsingService : public SafeBrowsingService {
47 public: 47 public:
48 MockSafeBrowsingService() {} 48 MockSafeBrowsingService() {}
49 virtual ~MockSafeBrowsingService() {}
50 49
51 MOCK_METHOD1(MatchDownloadWhitelistUrl, bool(const GURL&)); 50 MOCK_METHOD1(MatchDownloadWhitelistUrl, bool(const GURL&));
52 MOCK_METHOD1(MatchDownloadWhitelistString, bool(const std::string&)); 51 MOCK_METHOD1(MatchDownloadWhitelistString, bool(const std::string&));
53 MOCK_METHOD2(CheckDownloadUrl, bool(const std::vector<GURL>& url_chain, 52 MOCK_METHOD2(CheckDownloadUrl, bool(const std::vector<GURL>& url_chain,
54 Client* client)); 53 Client* client));
55 54
55 protected:
56 virtual ~MockSafeBrowsingService() {}
57
56 private: 58 private:
57 DISALLOW_COPY_AND_ASSIGN(MockSafeBrowsingService); 59 DISALLOW_COPY_AND_ASSIGN(MockSafeBrowsingService);
58 }; 60 };
59 61
60 class MockSignatureUtil : public SignatureUtil { 62 class MockSignatureUtil : public SignatureUtil {
61 public: 63 public:
62 MockSignatureUtil() {} 64 MockSignatureUtil() {}
63 virtual ~MockSignatureUtil() {}
64 MOCK_METHOD2(CheckSignature, 65 MOCK_METHOD2(CheckSignature,
65 void(const FilePath&, ClientDownloadRequest_SignatureInfo*)); 66 void(const FilePath&, ClientDownloadRequest_SignatureInfo*));
66 67
68 protected:
69 virtual ~MockSignatureUtil() {}
70
67 private: 71 private:
68 DISALLOW_COPY_AND_ASSIGN(MockSignatureUtil); 72 DISALLOW_COPY_AND_ASSIGN(MockSignatureUtil);
69 }; 73 };
70 } // namespace 74 } // namespace
71 75
72 ACTION_P(SetCertificateContents, contents) { 76 ACTION_P(SetCertificateContents, contents) {
73 arg1->add_certificate_chain()->add_element()->set_certificate(contents); 77 arg1->add_certificate_chain()->add_element()->set_certificate(contents);
74 } 78 }
75 79
76 ACTION_P(TrustSignature, certificate_file) { 80 ACTION_P(TrustSignature, certificate_file) {
(...skipping 664 matching lines...) Expand 10 before | Expand all | Expand 10 after
741 GetCertificateWhitelistStrings(*cert, *issuer_cert, &whitelist_strings); 745 GetCertificateWhitelistStrings(*cert, *issuer_cert, &whitelist_strings);
742 EXPECT_THAT(whitelist_strings, ElementsAre(cert_base + "/OU=unit")); 746 EXPECT_THAT(whitelist_strings, ElementsAre(cert_base + "/OU=unit"));
743 747
744 cert = ReadTestCertificate("test_c.pem"); 748 cert = ReadTestCertificate("test_c.pem");
745 ASSERT_TRUE(cert.get()); 749 ASSERT_TRUE(cert.get());
746 whitelist_strings.clear(); 750 whitelist_strings.clear();
747 GetCertificateWhitelistStrings(*cert, *issuer_cert, &whitelist_strings); 751 GetCertificateWhitelistStrings(*cert, *issuer_cert, &whitelist_strings);
748 EXPECT_THAT(whitelist_strings, ElementsAre()); 752 EXPECT_THAT(whitelist_strings, ElementsAre());
749 } 753 }
750 } // namespace safe_browsing 754 } // namespace safe_browsing
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698