Enable user resizing for docked Panels (GTK and Mac).

Enable user resizing for docked Panels (GTK and Mac).

Docked panels can be resized from all edges except the bottom.
Jianli will create a separate patch for Windows docked Panels.

This patch depends on http://codereview.chromium.org/10020057/ landing first.

BUG=None
TEST=Updated plus manual verification of resizing docked panels.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132296

[jennb, 2012-04-13 00:25:15]

Change in this patch affect your Windows patch for resizing docked panels.

[jennb, 2012-04-13 00:46:58]

Forgot to mention that I haven't finished the mac changes for this patch yet.
Need to switch machines...

[jianli, 2012-04-13 00:52:35]

http://codereview.chromium.org/10066032/diff/21/chrome/browser/ui/panels/pane...
File chrome/browser/ui/panels/panel_constants.h (right):

http://codereview.chromium.org/10066032/diff/21/chrome/browser/ui/panels/pane...
chrome/browser/ui/panels/panel_constants.h:35: ALL_SIDES,
Probably better to suffix with _RESIZABLE.

http://codereview.chromium.org/10066032/diff/21/chrome/browser/ui/panels/pane...
File chrome/browser/ui/panels/panel_resize_browsertest.cc (right):

http://codereview.chromium.org/10066032/diff/21/chrome/browser/ui/panels/pane...
chrome/browser/ui/panels/panel_resize_browsertest.cc:38: // Try resizing by the
top left corner; verify resize works.
I think it would be better to test all other edges now since some of edges can
be used for resizing while some others cannot.

http://codereview.chromium.org/10066032/diff/21/chrome/browser/ui/panels/pane...
File chrome/browser/ui/panels/panel_strip.h (right):

http://codereview.chromium.org/10066032/diff/21/chrome/browser/ui/panels/pane...
chrome/browser/ui/panels/panel_strip.h:66: // Returns whether/how |panel| can be
resized by the user when in this strip.
Probably clearer to say: returns the edges that can be used to resize |panel| by
the user if |panel| is resizable in this strip.

http://codereview.chromium.org/10066032/diff/21/chrome/browser/ui/panels/pane...
chrome/browser/ui/panels/panel_strip.h:67: virtual panel::Resizability
CanResizePanel(const Panel* panel) const = 0;
Can*** makes me think about the bool return value. How about GetResizableEdges
or GetUserResizableEdges?

[Dmitry Titov, 2012-04-13 02:55:45]

http://codereview.chromium.org/10066032/diff/21/chrome/browser/ui/panels/pane...
File chrome/browser/ui/panels/panel_constants.h (right):

http://codereview.chromium.org/10066032/diff/21/chrome/browser/ui/panels/pane...
chrome/browser/ui/panels/panel_constants.h:35: ALL_SIDES,
On 2012/04/13 00:52:36, jianli wrote:
> Probably better to suffix with _RESIZABLE.

Or prefix:
RESIZABLE_ALL_SIDES
RESIZABLE_ALL_SIDES_EXCEPT_BOTTOM

as in ResizingSides enum, it's better to have a relevant prefix because in call
sites we don't see the name of the enum, only enum values.

http://codereview.chromium.org/10066032/diff/21/chrome/browser/ui/panels/pane...
File chrome/browser/ui/panels/panel_strip.h (right):

http://codereview.chromium.org/10066032/diff/21/chrome/browser/ui/panels/pane...
chrome/browser/ui/panels/panel_strip.h:67: virtual panel::Resizability
CanResizePanel(const Panel* panel) const = 0;
On 2012/04/13 00:52:36, jianli wrote:
> Can*** makes me think about the bool return value. How about GetResizableEdges
> or GetUserResizableEdges?

GetPanelResizability()?

http://codereview.chromium.org/10066032/diff/21/chrome/browser/ui/panels/pane...
File chrome/browser/ui/panels/panel_window_controller_cocoa.mm (right):

http://codereview.chromium.org/10066032/diff/21/chrome/browser/ui/panels/pane...
chrome/browser/ui/panels/panel_window_controller_cocoa.mm:200: if
(NSMouseInRect(point, bottomLeftCursorRect_, flipped))
Why do we want the bottom corners to do horizontal resize? Will you also switch
the cursor rects to another type of cursor? Seems we can just remove the whole
bottom edge with corners from the equation here, instead of changing the
semantics of dragging the corner, w/o much benefit.

[jennb, 2012-04-13 16:39:43]

No new patch yet.

http://codereview.chromium.org/10066032/diff/21/chrome/browser/ui/panels/pane...
File chrome/browser/ui/panels/panel_window_controller_cocoa.mm (right):

http://codereview.chromium.org/10066032/diff/21/chrome/browser/ui/panels/pane...
chrome/browser/ui/panels/panel_window_controller_cocoa.mm:200: if
(NSMouseInRect(point, bottomLeftCursorRect_, flipped))
On 2012/04/13 02:55:45, Dmitry Titov wrote:
> Why do we want the bottom corners to do horizontal resize? Will you also
switch
> the cursor rects to another type of cursor? Seems we can just remove the whole
> bottom edge with corners from the equation here, instead of changing the
> semantics of dragging the corner, w/o much benefit.

I tried ignoring the bottom corners, but it didn't feel right. Ignoring them is
definitely easier. I'll switch back and see if users complain. I guess most
won't attempt to resize left/right with the mouse that low and I only noticed
because I was specifically checking how low you can go and still resize. 

You're right that I forgot to change the cursors for Mac.

[jennb, 2012-04-13 19:48:04]

Dimich - could you take over this patch as Jian is out today?

Resizing docked Mac panels now working.

http://codereview.chromium.org/10066032/diff/21/chrome/browser/ui/panels/pane...
File chrome/browser/ui/panels/panel_constants.h (right):

http://codereview.chromium.org/10066032/diff/21/chrome/browser/ui/panels/pane...
chrome/browser/ui/panels/panel_constants.h:35: ALL_SIDES,
On 2012/04/13 02:55:45, Dmitry Titov wrote:
> On 2012/04/13 00:52:36, jianli wrote:
> > Probably better to suffix with _RESIZABLE.
> 
> Or prefix:
> RESIZABLE_ALL_SIDES
> RESIZABLE_ALL_SIDES_EXCEPT_BOTTOM
> 
> as in ResizingSides enum, it's better to have a relevant prefix because in
call
> sites we don't see the name of the enum, only enum values.

Done.

http://codereview.chromium.org/10066032/diff/21/chrome/browser/ui/panels/pane...
File chrome/browser/ui/panels/panel_resize_browsertest.cc (right):

http://codereview.chromium.org/10066032/diff/21/chrome/browser/ui/panels/pane...
chrome/browser/ui/panels/panel_resize_browsertest.cc:38: // Try resizing by the
top left corner; verify resize works.
On 2012/04/13 00:52:36, jianli wrote:
> I think it would be better to test all other edges now since some of edges can
> be used for resizing while some others cannot.

Done.

http://codereview.chromium.org/10066032/diff/21/chrome/browser/ui/panels/pane...
File chrome/browser/ui/panels/panel_strip.h (right):

http://codereview.chromium.org/10066032/diff/21/chrome/browser/ui/panels/pane...
chrome/browser/ui/panels/panel_strip.h:66: // Returns whether/how |panel| can be
resized by the user when in this strip.
On 2012/04/13 00:52:36, jianli wrote:
> Probably clearer to say: returns the edges that can be used to resize |panel|
by
> the user if |panel| is resizable in this strip.

Done.

http://codereview.chromium.org/10066032/diff/21/chrome/browser/ui/panels/pane...
chrome/browser/ui/panels/panel_strip.h:67: virtual panel::Resizability
CanResizePanel(const Panel* panel) const = 0;
On 2012/04/13 02:55:45, Dmitry Titov wrote:
> On 2012/04/13 00:52:36, jianli wrote:
> > Can*** makes me think about the bool return value. How about
GetResizableEdges
> > or GetUserResizableEdges?
> 
> GetPanelResizability()?
> 

Done. Did not rename CanResizeByMouse() in this patch as I'll be renaming that
in a separate patch to replace ResizeByMouse to ResizeDrag.

[Dmitry Titov, 2012-04-13 21:52:56]

LGTM
The try bot failure seems unrelated, lets fix the test in a separate patch.

[commit-bot: I haz the power, 2012-04-13 22:03:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jennb@chromium.org/10066032/16001

[commit-bot: I haz the power, 2012-04-13 23:35:11]

Change committed as 132296