chrome/browser/ui/panels/panel_constants.h - Issue 10066032: Enable user resizing for docked Panels (GTK and Mac).

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/panels/panel_constants.h

Issue 10066032: Enable user resizing for docked Panels (GTK and Mac). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: minor cleanup Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/ui/panels/panel_browser_window_gtk.cc ('k') | chrome/browser/ui/panels/panel_manager.cc » ('j') | chrome/browser/ui/panels/panel_resize_browsertest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_UI_PANELS_PANEL_CONSTANTS_H_	5 #ifndef CHROME_BROWSER_UI_PANELS_PANEL_CONSTANTS_H_

6 #define CHROME_BROWSER_UI_PANELS_PANEL_CONSTANTS_H_	6 #define CHROME_BROWSER_UI_PANELS_PANEL_CONSTANTS_H_

7 #pragma once	7 #pragma once

8	8

9 namespace panel {	9 namespace panel {

10	10

(...skipping 11 matching lines...) Expand all Loading...
22 RESIZE_TOP,	22 RESIZE_TOP,

23 RESIZE_TOP_RIGHT,	23 RESIZE_TOP_RIGHT,

24 RESIZE_RIGHT,	24 RESIZE_RIGHT,

25 RESIZE_BOTTOM_RIGHT,	25 RESIZE_BOTTOM_RIGHT,

26 RESIZE_BOTTOM,	26 RESIZE_BOTTOM,

27 RESIZE_BOTTOM_LEFT,	27 RESIZE_BOTTOM_LEFT,

28 RESIZE_LEFT,	28 RESIZE_LEFT,

29 RESIZE_TOP_LEFT	29 RESIZE_TOP_LEFT

30 };	30 };

31	31

	32 // Ways a panel can be resized.

	33 enum Resizability {

	34 NOT_RESIZABLE,

	35 ALL_SIDES,
	jianli 2012/04/13 00:52:36 Probably better to suffix with _RESIZABLE. Probably better to suffix with _RESIZABLE. Dmitry Titov 2012/04/13 02:55:45 Or prefix: RESIZABLE_ALL_SIDES RESIZABLE_ALL_SIDES Show quoted text On 2012/04/13 00:52:36, jianli wrote: > Probably better to suffix with _RESIZABLE. Or prefix: RESIZABLE_ALL_SIDES RESIZABLE_ALL_SIDES_EXCEPT_BOTTOM as in ResizingSides enum, it's better to have a relevant prefix because in call sites we don't see the name of the enum, only enum values. jennb 2012/04/13 19:48:04 Done. Show quoted text On 2012/04/13 02:55:45, Dmitry Titov wrote: > On 2012/04/13 00:52:36, jianli wrote: > > Probably better to suffix with _RESIZABLE. > > Or prefix: > RESIZABLE_ALL_SIDES > RESIZABLE_ALL_SIDES_EXCEPT_BOTTOM > > as in ResizingSides enum, it's better to have a relevant prefix because in call > sites we don't see the name of the enum, only enum values. Done.
	36 ALL_SIDES_EXCEPT_BOTTOM

	37 };

	38

32 } // namespace panel	39 } // namespace panel

33	40

34 #endif // CHROME_BROWSER_UI_PANELS_PANEL_CONSTANTS_H_	41 #endif // CHROME_BROWSER_UI_PANELS_PANEL_CONSTANTS_H_

OLD	NEW