Enable user resizing for docked Panels (GTK and Mac).

chrome/browser/ui/panels/panel_window_controller_cocoa.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/panels/panel_window_controller_cocoa.h"
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/auto_reset.h"
 #include "base/logging.h"
@@ skipping 154 matching lines @@
   }
   return self;
 }
 
 - (BOOL)acceptsFirstMouse:(NSEvent*)event {
   return YES;
 }
 
 // |pointInWindow| is in window coordinates.
 - (panel::ResizingSides)edgeHitTest:(NSPoint)pointInWindow {
-  DCHECK(panel_->CanResizeByMouse());
+  panel::Resizability resizability = panel_->CanResizeByMouse();
+  DCHECK_NE(panel::NOT_RESIZABLE, resizability);
 
   NSPoint point = [self convertPoint:pointInWindow fromView:nil];
   BOOL flipped = [self isFlipped];
   if (NSMouseInRect(point, leftCursorRect_, flipped))
     return panel::RESIZE_LEFT;
   if (NSMouseInRect(point, rightCursorRect_, flipped))
     return panel::RESIZE_RIGHT;
   if (NSMouseInRect(point, topCursorRect_, flipped))
     return panel::RESIZE_TOP;
-  if (NSMouseInRect(point, bottomCursorRect_, flipped))
-    return panel::RESIZE_BOTTOM;
   if (NSMouseInRect(point, topLeftCursorRect_, flipped))
     return panel::RESIZE_TOP_LEFT;
   if (NSMouseInRect(point, topRightCursorRect_, flipped))
     return panel::RESIZE_TOP_RIGHT;
-  if (NSMouseInRect(point, bottomLeftCursorRect_, flipped))
-    return panel::RESIZE_BOTTOM_LEFT;
-  if (NSMouseInRect(point, bottomRightCursorRect_, flipped))
-    return panel::RESIZE_BOTTOM_RIGHT;
+
+  // Special handling if bottom edge is not resizable.
+  if (panel::ALL_SIDES == resizability) {
+    if (NSMouseInRect(point, bottomCursorRect_, flipped))
+      return panel::RESIZE_BOTTOM;
+    if (NSMouseInRect(point, bottomLeftCursorRect_, flipped))
+      return panel::RESIZE_BOTTOM_LEFT;
+    if (NSMouseInRect(point, bottomRightCursorRect_, flipped))
+      return panel::RESIZE_BOTTOM_RIGHT;
+  } else if (panel::ALL_SIDES_EXCEPT_BOTTOM == resizability) {
+    if (NSMouseInRect(point, bottomLeftCursorRect_, flipped))

[Dmitry Titov, 2012/04/13 02:55:45]

Why do we want the bottom corners to do horizontal resize? Will you also switch
the cursor rects to another type of cursor? Seems we can just remove the whole
bottom edge with corners from the equation here, instead of changing the
semantics of dragging the corner, w/o much benefit.

[jennb, 2012/04/13 16:39:43]

I tried ignoring the bottom corners, but it didn't feel right. Ignoring them is
definitely easier. I'll switch back and see if users complain. I guess most
won't attempt to resize left/right with the mouse that low and I only noticed
because I was specifically checking how low you can go and still resize. 

You're right that I forgot to change the cursors for Mac.

+      return panel::RESIZE_LEFT;
+    if (NSMouseInRect(point, bottomRightCursorRect_, flipped))
+      return panel::RESIZE_RIGHT;
+  }
 
   return panel::RESIZE_NONE;
 }
 
 // NSWindow uses this method to figure out if this view is under the mouse
 // and hence the one to handle the incoming mouse event.
 // Since this view covers the whole panel, it is asked first.
 // See if this is the mouse event we are interested in (in the resize areas)
 // and return 'nil' to let NSWindow find another candidate otherwise.
 // |point| is in coordinate system of the parent view.
 - (NSView*)hitTest:(NSPoint)point {
   // If panel is not resizable, let the mouse events fall through.
-  if (!panel_->CanResizeByMouse())
+  if (panel::NOT_RESIZABLE == panel_->CanResizeByMouse())
     return nil;
 
   NSPoint pointInWindow = [[self superview] convertPoint:point toView:nil];
   return [self edgeHitTest:pointInWindow] == panel::RESIZE_NONE ? nil : self;
 }
 
 - (void)mouseDown:(NSEvent*)event {
   // If the panel is not resizable, hitTest should have failed and no mouse
   // events should have came here.
-  DCHECK(panel_->CanResizeByMouse());
+  DCHECK_NE(panel::NOT_RESIZABLE, panel_->CanResizeByMouse());
   [self prepareForDrag:event];
 }
 
 - (void)mouseUp:(NSEvent*)event {
   // The mouseUp while in drag should be processed by nested message loop
   // in mouseDragged: method.
   DCHECK(dragState_ != PANEL_DRAG_IN_PROGRESS);
   // Cleanup in case the actual drag was not started (because of threshold).
   [self cleanupAfterDrag];
 }
@@ skipping 130 matching lines @@
   panel_->manager()->ResizeByMouse(
       cocoa_utils::ConvertPointFromCocoaCoordinates(mouseLocationScreen));
 }
 
 - (void)endResize:(BOOL)cancelled {
   DCHECK(dragState_ == PANEL_DRAG_IN_PROGRESS);
   panel_->manager()->EndResizingByMouse(cancelled);
 }
 
 - (void)resetCursorRects {
-  if(!panel_->CanResizeByMouse())
+  if(panel::NOT_RESIZABLE == panel_->CanResizeByMouse())
     return;
 
   NSRect bounds = [self bounds];
 
   // Left vertical edge.
   leftCursorRect_ = NSMakeRect(NSMinX(bounds),
                                NSMinY(bounds) + kWidthOfMouseResizeArea,
                                kWidthOfMouseResizeArea,
                                NSHeight(bounds) - 2 * kWidthOfMouseResizeArea);
   [self addCursorRect:leftCursorRect_ cursor:eastWestCursor_];
@@ skipping 695 matching lines @@
   if (![self isWindowLoaded])
     return;
   [[self window] invalidateCursorRectsForView:overlayView_];
 }
 
 - (BOOL)isActivationByClickingTitlebarEnabled {
   return !windowShim_->panel()->always_on_top();
 }
 
 @end