Enable user resizing for docked Panels (GTK and Mac).

chrome/browser/ui/panels/panel_window_controller_cocoa.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/panels/panel_window_controller_cocoa.h"
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/auto_reset.h"
 #include "base/logging.h"
@@ skipping 154 matching lines @@
   }
   return self;
 }
 
 - (BOOL)acceptsFirstMouse:(NSEvent*)event {
   return YES;
 }
 
 // |pointInWindow| is in window coordinates.
 - (panel::ResizingSides)edgeHitTest:(NSPoint)pointInWindow {
-  DCHECK(panel_->CanResizeByMouse());
+  panel::Resizability resizability = panel_->CanResizeByMouse();
+  DCHECK_NE(panel::NOT_RESIZABLE, resizability);
 
   NSPoint point = [self convertPoint:pointInWindow fromView:nil];
   BOOL flipped = [self isFlipped];
   if (NSMouseInRect(point, leftCursorRect_, flipped))
     return panel::RESIZE_LEFT;
   if (NSMouseInRect(point, rightCursorRect_, flipped))
     return panel::RESIZE_RIGHT;
   if (NSMouseInRect(point, topCursorRect_, flipped))
     return panel::RESIZE_TOP;
-  if (NSMouseInRect(point, bottomCursorRect_, flipped))
-    return panel::RESIZE_BOTTOM;
   if (NSMouseInRect(point, topLeftCursorRect_, flipped))
     return panel::RESIZE_TOP_LEFT;
   if (NSMouseInRect(point, topRightCursorRect_, flipped))
     return panel::RESIZE_TOP_RIGHT;
-  if (NSMouseInRect(point, bottomLeftCursorRect_, flipped))
-    return panel::RESIZE_BOTTOM_LEFT;
-  if (NSMouseInRect(point, bottomRightCursorRect_, flipped))
-    return panel::RESIZE_BOTTOM_RIGHT;
+
+  // Bottom edge is not always resizable.
+  if (panel::RESIZABLE_ALL_SIDES == resizability) {
+    if (NSMouseInRect(point, bottomCursorRect_, flipped))
+      return panel::RESIZE_BOTTOM;
+    if (NSMouseInRect(point, bottomLeftCursorRect_, flipped))
+      return panel::RESIZE_BOTTOM_LEFT;
+    if (NSMouseInRect(point, bottomRightCursorRect_, flipped))
+      return panel::RESIZE_BOTTOM_RIGHT;
+  }
 
   return panel::RESIZE_NONE;
 }
 
 // NSWindow uses this method to figure out if this view is under the mouse
 // and hence the one to handle the incoming mouse event.
 // Since this view covers the whole panel, it is asked first.
 // See if this is the mouse event we are interested in (in the resize areas)
 // and return 'nil' to let NSWindow find another candidate otherwise.
 // |point| is in coordinate system of the parent view.
 - (NSView*)hitTest:(NSPoint)point {
   // If panel is not resizable, let the mouse events fall through.
-  if (!panel_->CanResizeByMouse())
+  if (panel::NOT_RESIZABLE == panel_->CanResizeByMouse())
     return nil;
 
   NSPoint pointInWindow = [[self superview] convertPoint:point toView:nil];
   return [self edgeHitTest:pointInWindow] == panel::RESIZE_NONE ? nil : self;
 }
 
 - (void)mouseDown:(NSEvent*)event {
   // If the panel is not resizable, hitTest should have failed and no mouse
   // events should have came here.
-  DCHECK(panel_->CanResizeByMouse());
+  DCHECK_NE(panel::NOT_RESIZABLE, panel_->CanResizeByMouse());
   [self prepareForDrag:event];
 }
 
 - (void)mouseUp:(NSEvent*)event {
   // The mouseUp while in drag should be processed by nested message loop
   // in mouseDragged: method.
   DCHECK(dragState_ != PANEL_DRAG_IN_PROGRESS);
   // Cleanup in case the actual drag was not started (because of threshold).
   [self cleanupAfterDrag];
 }
@@ skipping 130 matching lines @@
   panel_->manager()->ResizeByMouse(
       cocoa_utils::ConvertPointFromCocoaCoordinates(mouseLocationScreen));
 }
 
 - (void)endResize:(BOOL)cancelled {
   DCHECK(dragState_ == PANEL_DRAG_IN_PROGRESS);
   panel_->manager()->EndResizingByMouse(cancelled);
 }
 
 - (void)resetCursorRects {
-  if(!panel_->CanResizeByMouse())
+  panel::Resizability resizability = panel_->CanResizeByMouse();
+  if (panel::NOT_RESIZABLE == resizability)
     return;
 
   NSRect bounds = [self bounds];
 
   // Left vertical edge.
   leftCursorRect_ = NSMakeRect(NSMinX(bounds),
                                NSMinY(bounds) + kWidthOfMouseResizeArea,
                                kWidthOfMouseResizeArea,
                                NSHeight(bounds) - 2 * kWidthOfMouseResizeArea);
   [self addCursorRect:leftCursorRect_ cursor:eastWestCursor_];
 
   // Right vertical edge.
   rightCursorRect_ = leftCursorRect_;
   rightCursorRect_.origin.x = NSMaxX(bounds) - kWidthOfMouseResizeArea;
   [self addCursorRect:rightCursorRect_ cursor:eastWestCursor_];
 
   // Top horizontal edge.
   topCursorRect_ = NSMakeRect(NSMinX(bounds) + kWidthOfMouseResizeArea,
                               NSMaxY(bounds) - kWidthOfMouseResizeArea,
                               NSWidth(bounds) - 2 * kWidthOfMouseResizeArea,
                               kWidthOfMouseResizeArea);
   [self addCursorRect:topCursorRect_ cursor:northSouthCursor_];
 
-  // Bottom horizontal edge.
-  bottomCursorRect_ = topCursorRect_;
-  bottomCursorRect_.origin.y = NSMinY(bounds);
-  [self addCursorRect:bottomCursorRect_ cursor:northSouthCursor_];
-
   // Top left corner.
   topLeftCursorRect_ = NSMakeRect(NSMinX(bounds),
                                   NSMaxY(bounds) - kWidthOfMouseResizeArea,
                                   kWidthOfMouseResizeArea,
                                   NSMaxY(bounds));
   [self addCursorRect:topLeftCursorRect_ cursor:northWestSouthEastCursor_];
 
   // Top right corner.
   topRightCursorRect_ = topLeftCursorRect_;
   topRightCursorRect_.origin.x = NSMaxX(bounds) - kWidthOfMouseResizeArea;
   [self addCursorRect:topRightCursorRect_ cursor:northEastSouthWestCursor_];
 
+  // Bottom edge is not always resizable.
+  if (panel::RESIZABLE_ALL_SIDES_EXCEPT_BOTTOM == resizability)
+    return;
+
+  // Bottom horizontal edge.
+  bottomCursorRect_ = topCursorRect_;
+  bottomCursorRect_.origin.y = NSMinY(bounds);
+  [self addCursorRect:bottomCursorRect_ cursor:northSouthCursor_];
+
   // Bottom right corner.
   bottomRightCursorRect_ = topRightCursorRect_;
   bottomRightCursorRect_.origin.y = NSMinY(bounds);
   [self addCursorRect:bottomRightCursorRect_ cursor:northWestSouthEastCursor_];
 
   // Bottom left corner.
   bottomLeftCursorRect_ = bottomRightCursorRect_;
   bottomLeftCursorRect_.origin.x = NSMinX(bounds);
   [self addCursorRect:bottomLeftCursorRect_ cursor:northEastSouthWestCursor_];
 }
@@ skipping 655 matching lines @@
   if (![self isWindowLoaded])
     return;
   [[self window] invalidateCursorRectsForView:overlayView_];
 }
 
 - (BOOL)isActivationByClickingTitlebarEnabled {
   return !windowShim_->panel()->always_on_top();
 }
 
 @end