|
Initial support for inspecting extension popups.
The primary change in this CL is a refactor which makes ExtensionPopup a bit more self-contained WRT its clients. It adds the ability to specify an "inspect_with_devtools" flag to its Show() method which will cause the popup to remain open regardless of losing focus and to focus a devtools window on the popup's render view host.
This CL also pulls apart some aspects of the extension_popup_api from ExtensionFunctionDispatcher and ExtensionHost.
Still remaining to be done are:
1) Also the popup to stay open when the host window drags (it current closes)
2) Support for GTK
3) Support for Mac
BUG= 24477
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41854
Total comments: 48
Total comments: 1
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+462 lines, -557 lines) |
Patch |
![](/static/closedtriangle.gif) |
M |
chrome/app/generated_resources.grd
|
View
|
1
2
3
4
5
6
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/debugger/devtools_manager.cc
|
View
|
|
1 chunk |
+6 lines, -0 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/extensions/extension_action_context_menu_model.h
|
View
|
1
2
3
4
5
6
7
|
3 chunks |
+27 lines, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/extensions/extension_action_context_menu_model.cc
|
View
|
1
2
3
4
5
6
|
4 chunks |
+34 lines, -3 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/extensions/extension_dom_ui.h
|
View
|
|
3 chunks |
+0 lines, -4 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/extensions/extension_function_dispatcher.h
|
View
|
1
2
3
4
5
6
|
2 chunks |
+0 lines, -5 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/extensions/extension_function_dispatcher.cc
|
View
|
1
2
3
4
5
6
|
1 chunk |
+0 lines, -12 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/extensions/extension_host.h
|
View
|
1
2
3
4
5
6
|
4 chunks |
+5 lines, -7 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/extensions/extension_popup_api.cc
|
View
|
1
2
3
|
3 chunks |
+108 lines, -9 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
D |
chrome/browser/extensions/extension_popup_host.h
|
View
|
1
2
3
4
5
6
|
1 chunk |
+0 lines, -113 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
D |
chrome/browser/extensions/extension_popup_host.cc
|
View
|
|
1 chunk |
+0 lines, -202 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/gtk/browser_actions_toolbar_gtk.cc
|
View
|
1
2
3
4
5
6
|
1 chunk |
+4 lines, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/gtk/location_bar_view_gtk.cc
|
View
|
1
2
3
4
5
6
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/views/browser_actions_container.h
|
View
|
1
2
3
4
5
|
6 chunks |
+15 lines, -17 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
|
chrome/browser/views/browser_actions_container.cc
|
View
|
1
2
3
|
10 chunks |
+31 lines, -85 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/views/extensions/browser_action_overflow_menu_controller.cc
|
View
|
|
3 chunks |
+8 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/views/extensions/extension_action_context_menu.h
|
View
|
1
2
3
4
5
|
2 chunks |
+7 lines, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/views/extensions/extension_action_context_menu.cc
|
View
|
1
2
3
4
5
|
1 chunk |
+6 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/views/extensions/extension_popup.h
|
View
|
1
2
3
4
5
6
|
7 chunks |
+51 lines, -3 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/views/extensions/extension_popup.cc
|
View
|
1
2
3
|
7 chunks |
+107 lines, -11 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/views/infobars/extension_infobar.cc
|
View
|
7
|
1 chunk |
+7 lines, -3 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/views/location_bar_view.h
|
View
|
1
2
3
4
5
|
5 chunks |
+11 lines, -17 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/views/location_bar_view.cc
|
View
|
1
2
3
|
7 chunks |
+25 lines, -56 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/chrome_browser.gypi
|
View
|
1
2
3
4
5
6
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/common/notification_type.h
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
Total messages: 4 (0 generated)
|