Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1859)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/gtk/browser_actions_toolbar_gtk.cc

Issue 1001002: Initial support for inspecting extension popups. (Closed)
Patch Set: pre submit Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_popup_host.cc ('k') | chrome/browser/gtk/location_bar_view_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/gtk/browser_actions_toolbar_gtk.cc
diff --git a/chrome/browser/gtk/browser_actions_toolbar_gtk.cc b/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
index 621a42f388d12be4c3f2741f9b31f96c4105cba9..5ab13c6797300c9dcd1444baa5f4a131e1c37fca 100644
--- a/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
+++ b/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
@@ -188,9 +188,12 @@ class BrowserActionButton : public NotificationObserver,
if (event->button.button != 3)
return FALSE;
+ // TODO(rafaelw): support inspecting popups.
if (!action->context_menu_model_.get()) {
action->context_menu_model_.reset(
- new ExtensionActionContextMenuModel(action->extension_));
+ new ExtensionActionContextMenuModel(action->extension_,
+ action->extension_->browser_action(),
+ action->toolbar_->browser()->profile()->GetPrefs(), NULL));
}
action->context_menu_.reset(
« no previous file with comments | « chrome/browser/extensions/extension_popup_host.cc ('k') | chrome/browser/gtk/location_bar_view_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698